You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-dev@hadoop.apache.org by Ivan Kelly <iv...@apache.org> on 2012/03/07 18:38:30 UTC

Review Request: HDFS-3058 HA: Bring BookKeeperJournalManager up to date with HA changes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4230/
-----------------------------------------------------------

Review request for hadoop-hdfs.


Summary
-------

There's a couple of TODO(HA) comments in the BookKeeperJournalManager code. This JIRA is to address those.


This addresses bug HDFS-3058.
    http://issues.apache.org/jira/browse/HDFS-3058


Diffs
-----

  hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/pom.xml 1fba846 
  hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/main/java/org/apache/hadoop/contrib/bkjournal/BookKeeperEditLogInputStream.java 636471a 
  hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/main/java/org/apache/hadoop/contrib/bkjournal/BookKeeperJournalManager.java 047efd5 
  hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/BKJMUtil.java PRE-CREATION 
  hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/TestBookKeeperAsHASharedDir.java PRE-CREATION 
  hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/TestBookKeeperHACheckpoints.java PRE-CREATION 
  hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/TestBookKeeperJournalManager.java 5937fa8 
  hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogTestUtil.java 6557b96 
  hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java 7c630d7 
  hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java 8888bec 
  hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestStandbyCheckpoints.java 5440c38 

Diff: https://reviews.apache.org/r/4230/diff


Testing
-------


Thanks,

Ivan


Re: Review Request: HDFS-3058 HA: Bring BookKeeperJournalManager up to date with HA changes

Posted by Ivan Kelly <iv...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4230/
-----------------------------------------------------------

(Updated 2012-05-18 15:43:52.712478)


Review request for hadoop-hdfs.


Summary
-------

There's a couple of TODO(HA) comments in the BookKeeperJournalManager code. This JIRA is to address those.


This addresses bug HDFS-3058.
    http://issues.apache.org/jira/browse/HDFS-3058


Diffs (updated)
-----

  hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/pom.xml 380ef62 
  hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/main/java/org/apache/hadoop/contrib/bkjournal/BookKeeperEditLogInputStream.java 9d070d9 
  hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/main/java/org/apache/hadoop/contrib/bkjournal/BookKeeperJournalManager.java 047efd5 
  hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/BKJMUtil.java PRE-CREATION 
  hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/TestBookKeeperAsHASharedDir.java PRE-CREATION 
  hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/TestBookKeeperHACheckpoints.java PRE-CREATION 
  hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/TestBookKeeperJournalManager.java 5937fa8 
  hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogTestUtil.java 41f0292 
  hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java c144906 
  hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java b418fcf 
  hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestStandbyCheckpoints.java 5440c38 

Diff: https://reviews.apache.org/r/4230/diff


Testing
-------


Thanks,

Ivan


Re: Review Request: HDFS-3058 HA: Bring BookKeeperJournalManager up to date with HA changes

Posted by Ivan Kelly <iv...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4230/
-----------------------------------------------------------

(Updated 2012-05-10 14:44:08.706764)


Review request for hadoop-hdfs.


Summary
-------

There's a couple of TODO(HA) comments in the BookKeeperJournalManager code. This JIRA is to address those.


This addresses bug HDFS-3058.
    http://issues.apache.org/jira/browse/HDFS-3058


Diffs (updated)
-----

  hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/pom.xml 380ef62 
  hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/main/java/org/apache/hadoop/contrib/bkjournal/BookKeeperEditLogInputStream.java 9d070d9 
  hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/main/java/org/apache/hadoop/contrib/bkjournal/BookKeeperJournalManager.java 7fa9026 
  hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/BKJMUtil.java PRE-CREATION 
  hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/TestBookKeeperAsHASharedDir.java PRE-CREATION 
  hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/TestBookKeeperHACheckpoints.java PRE-CREATION 
  hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/TestBookKeeperJournalManager.java b949bc2 
  hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogTestUtil.java 41f0292 
  hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java c144906 
  hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java 3810614 
  hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestStandbyCheckpoints.java 5440c38 

Diff: https://reviews.apache.org/r/4230/diff


Testing
-------


Thanks,

Ivan