You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/01/04 21:48:00 UTC
[jira] [Work logged] (GOBBLIN-1340) Extend Azkaban client
[ https://issues.apache.org/jira/browse/GOBBLIN-1340?focusedWorklogId=530922&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-530922 ]
ASF GitHub Bot logged work on GOBBLIN-1340:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jan/21 21:47
Start Date: 04/Jan/21 21:47
Worklog Time Spent: 10m
Work Description: aplex commented on a change in pull request #3176:
URL: https://github.com/apache/incubator-gobblin/pull/3176#discussion_r551587674
##########
File path: gobblin-modules/gobblin-azkaban/src/main/java/org/apache/gobblin/service/modules/orchestration/AzkabanClient.java
##########
@@ -97,7 +86,8 @@ protected AzkabanClient(String username,
long sessionExpireInMin,
CloseableHttpClient httpClient,
SessionManager sessionManager,
- ExecutorService executorService)
+ ExecutorService executorService,
Review comment:
This is a builder constructor. I don't think it makes sense to have a backward-compatible overload every time we add a setting here, we'll end up wit a lot of overloads.
##########
File path: gobblin-modules/gobblin-azkaban/src/test/java/org/apache/gobblin/service/modules/orchestration/AzkabanClientTest.java
##########
@@ -48,9 +41,14 @@
* Please check https://azkaban.github.io/azkaban/docs/latest/ for how to setup Azkaban-solo-server.
*/
@Slf4j
+@Test(enabled = false)
Review comment:
All those tests were actually disabled by default, because they require local Azkaban to be set up. We can look into automatically starting & shutting it down as a follow up improvement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 530922)
Time Spent: 0.5h (was: 20m)
> Extend Azkaban client
> ---------------------
>
> Key: GOBBLIN-1340
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1340
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Reporter: Alex Prokofiev
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> We're going to add extra features to Azkaban client to support end-to-end testing framework.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)