You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/12/01 23:06:17 UTC
[GitHub] [geode] kirklund opened a new pull request #5799: DRAFT: GEODE-8634: Fix AsyncInvocationTimeoutDistributedTest flakiness
kirklund opened a new pull request #5799:
URL: https://github.com/apache/geode/pull/5799
Null out latch and threadId before each test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jchen21 commented on pull request #5799: GEODE-8634: Fix AsyncInvocationTimeoutDistributedTest flakiness
Posted by GitBox <gi...@apache.org>.
jchen21 commented on pull request #5799:
URL: https://github.com/apache/geode/pull/5799#issuecomment-739089189
> ConcurrentSerialGatewaySenderOperationsDistributedTest failed.
That is due to GEODE-8573, which fails more frequently recently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kirklund merged pull request #5799: GEODE-8634: Fix AsyncInvocationTimeoutDistributedTest flakiness
Posted by GitBox <gi...@apache.org>.
kirklund merged pull request #5799:
URL: https://github.com/apache/geode/pull/5799
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kirklund commented on pull request #5799: GEODE-8634: Fix AsyncInvocationTimeoutDistributedTest flakiness
Posted by GitBox <gi...@apache.org>.
kirklund commented on pull request #5799:
URL: https://github.com/apache/geode/pull/5799#issuecomment-739057694
ConcurrentSerialGatewaySenderOperationsDistributedTest failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kirklund commented on a change in pull request #5799: GEODE-8634: Fix AsyncInvocationTimeoutDistributedTest flakiness
Posted by GitBox <gi...@apache.org>.
kirklund commented on a change in pull request #5799:
URL: https://github.com/apache/geode/pull/5799#discussion_r535752559
##########
File path: geode-dunit/src/distributedTest/java/org/apache/geode/test/dunit/tests/AsyncInvocationTimeoutDistributedTest.java
##########
@@ -40,12 +41,20 @@
private static final long TIMEOUT_MILLIS = getTimeout().toMillis();
- private static final AtomicReference<Long> threadId = new AtomicReference<>();
+ private static final AtomicReference<Long> threadId = new AtomicReference<>(0L);
private static final AtomicReference<CountDownLatch> latch = new AtomicReference<>();
@Rule
public DistributedRule distributedRule = new DistributedRule();
+ @Before
+ public void setUp() {
+ getVM(0).invoke(() -> {
+ latch.set(null);
Review comment:
Yes, it would be better to avoid nulls and use CountDownLatch(0). Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jchen21 commented on a change in pull request #5799: GEODE-8634: Fix AsyncInvocationTimeoutDistributedTest flakiness
Posted by GitBox <gi...@apache.org>.
jchen21 commented on a change in pull request #5799:
URL: https://github.com/apache/geode/pull/5799#discussion_r535576021
##########
File path: geode-dunit/src/distributedTest/java/org/apache/geode/test/dunit/tests/AsyncInvocationTimeoutDistributedTest.java
##########
@@ -40,12 +41,20 @@
private static final long TIMEOUT_MILLIS = getTimeout().toMillis();
- private static final AtomicReference<Long> threadId = new AtomicReference<>();
+ private static final AtomicReference<Long> threadId = new AtomicReference<>(0L);
private static final AtomicReference<CountDownLatch> latch = new AtomicReference<>();
@Rule
public DistributedRule distributedRule = new DistributedRule();
+ @Before
+ public void setUp() {
+ getVM(0).invoke(() -> {
+ latch.set(null);
Review comment:
Is it better to initialize `latch` to `CountDownLatch(0)` instead of `null`? Also initialize it in line 45, when `latch` is declared?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kirklund commented on pull request #5799: GEODE-8634: Fix AsyncInvocationTimeoutDistributedTest flakiness
Posted by GitBox <gi...@apache.org>.
kirklund commented on pull request #5799:
URL: https://github.com/apache/geode/pull/5799#issuecomment-738235917
I changed setUp to set threadId to zero instead of null to avoid NPE being thrown by this line:
{{{
await().until(() -> threadId.get() > 0);
}}}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kirklund edited a comment on pull request #5799: GEODE-8634: Fix AsyncInvocationTimeoutDistributedTest flakiness
Posted by GitBox <gi...@apache.org>.
kirklund edited a comment on pull request #5799:
URL: https://github.com/apache/geode/pull/5799#issuecomment-738235917
I changed setUp to set threadId to zero instead of null to avoid NPE being thrown by this line:
```
await().until(() -> threadId.get() > 0);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kirklund commented on a change in pull request #5799: GEODE-8634: Fix AsyncInvocationTimeoutDistributedTest flakiness
Posted by GitBox <gi...@apache.org>.
kirklund commented on a change in pull request #5799:
URL: https://github.com/apache/geode/pull/5799#discussion_r536289547
##########
File path: geode-dunit/src/distributedTest/java/org/apache/geode/test/dunit/tests/AsyncInvocationTimeoutDistributedTest.java
##########
@@ -40,12 +41,20 @@
private static final long TIMEOUT_MILLIS = getTimeout().toMillis();
- private static final AtomicReference<Long> threadId = new AtomicReference<>();
+ private static final AtomicReference<Long> threadId = new AtomicReference<>(0L);
private static final AtomicReference<CountDownLatch> latch = new AtomicReference<>();
@Rule
public DistributedRule distributedRule = new DistributedRule();
+ @Before
+ public void setUp() {
+ getVM(0).invoke(() -> {
+ latch.set(null);
Review comment:
I think I've resolved this. Please take a look. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org