[jira] [Commented] (HBASE-7104) HBase includes multiple versions of netty: 3.5.0; 3.2.4; 3.2.2

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-7104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491402#comment-13491402 ] 

Hadoop QA commented on HBASE-7104:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12552262/7104.v1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 77 warning messages.

    {color:red}-1 javac{color}.  The patch appears to cause mvn compile goal to fail.

    {color:red}-1 findbugs{color}.  The patch appears to cause Findbugs (version 1.3.9) to fail.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.regionserver.TestSplitTransaction

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3232//testReport/
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3232//console

This message is automatically generated.
                
> HBase includes multiple versions of netty: 3.5.0; 3.2.4; 3.2.2
> --------------------------------------------------------------
>
>                 Key: HBASE-7104
>                 URL: https://issues.apache.org/jira/browse/HBASE-7104
>             Project: HBase
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.96.0
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 7104.v1.patch
>
>
> We've got 3 of them on trunk.
> [INFO] org.apache.hbase:hbase-server:jar:0.95-SNAPSHOT
> [INFO] +- io.netty:netty:jar:3.5.0.Final:compile
> [INFO] +- org.apache.zookeeper:zookeeper:jar:3.4.3:compile
> [INFO] |  \- org.jboss.netty:netty:jar:3.2.2.Final:compile
> [INFO] org.apache.hbase:hbase-hadoop2-compat:jar:0.95-SNAPSHOT
> [INFO] +- org.apache.hadoop:hadoop-client:jar:2.0.2-alpha:compile
> [INFO] |  +- org.apache.hadoop:hadoop-mapreduce-client-app:jar:2.0.2-alpha:compile
> [INFO] |  |  \- org.jboss.netty:netty:jar:3.2.4.Final:compile
> The patch attached:
> - fixes this for hadoop 1 profile
> - bump the netty version to 3.5.9
> - does not fix it for hadoop 2. I don't know why, but I haven't investigate: as it's still alpha may be they will change the version on hadoop side anyway.
> Tests are ok.
> I haven't really investigated the differences between netty 3.2 and 3.5. A quick search seems to say it's ok, but don't hesitate to raise a warning...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira