[GitHub] [superset] graceguo-supercat commented on a change in pull request #12906: fix: Config for dataset health check

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #12906:
URL: https://github.com/apache/superset/pull/12906#discussion_r569046689



##########
File path: superset/config.py
##########
@@ -1100,7 +1104,3 @@ class CeleryConfig:  # pylint: disable=too-few-public-methods
     except Exception:
         logger.exception("Found but failed to import local superset_config")
         raise
-
-# It's possible to add a dataset health check logic which is specific to your system.

Review comment:
       config list below won't be able to be overwritten. Have to move it up.

##########
File path: superset/config.py
##########
@@ -1100,7 +1104,3 @@ class CeleryConfig:  # pylint: disable=too-few-public-methods
     except Exception:
         logger.exception("Found but failed to import local superset_config")
         raise
-
-# It's possible to add a dataset health check logic which is specific to your system.

Review comment:
       config list below the overwrite function won't be able to be able 
    be overwritten. Have to move it up.

##########
File path: superset/connectors/sqla/models.py
##########
@@ -704,7 +704,11 @@ def data(self) -> Dict[str, Any]:
             data_["fetch_values_predicate"] = self.fetch_values_predicate
             data_["template_params"] = self.template_params
             data_["is_sqllab_view"] = self.is_sqllab_view
-            data_["health_check_message"] = self.health_check_message
+            data_["health_check_message"] = (

Review comment:
       do not return health check message, when feature is disabled but had populated health check message before.

##########
File path: superset/connectors/sqla/models.py
##########
@@ -704,7 +704,11 @@ def data(self) -> Dict[str, Any]:
             data_["fetch_values_predicate"] = self.fetch_values_predicate
             data_["template_params"] = self.template_params
             data_["is_sqllab_view"] = self.is_sqllab_view
-            data_["health_check_message"] = self.health_check_message
+            data_["health_check_message"] = (

Review comment:
       Should not return health check message, when feature is disabled but had populated health check message before.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org