You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Pete Wyckoff (JIRA)" <ji...@apache.org> on 2008/08/16 00:09:44 UTC

[jira] Created: (HADOOP-3963) libhdfs should never exit on its own but rather return errors to the calling application

libhdfs should never exit on its own but rather return errors to the calling application
----------------------------------------------------------------------------------------

                 Key: HADOOP-3963
                 URL: https://issues.apache.org/jira/browse/HADOOP-3963
             Project: Hadoop Core
          Issue Type: Improvement
          Components: libhdfs
            Reporter: Pete Wyckoff
            Priority: Minor


A a library, libhdfs would be better to return errors rather than directly exiting. This way the calling application can determine what to do on error. And it is more unix library like to handle errors this way.

Some applications like fuse-dfs need to handle the exit themselves after emitting an appropriate error message to its log.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3963) libhdfs should never exit on its own but rather return errors to the calling application

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-3963:
----------------------------------

    Status: Open  (was: Patch Available)

This looks fine, except for where you commented out the exits. We always prefer to actually remove the code and count on version control to put it back if needed.

> libhdfs should never exit on its own but rather return errors to the calling application
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3963
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3963
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: libhdfs
>            Reporter: Pete Wyckoff
>            Assignee: Pete Wyckoff
>            Priority: Minor
>         Attachments: patch0.txt
>
>
> A a library, libhdfs would be better to return errors rather than directly exiting. This way the calling application can determine what to do on error. And it is more unix library like to handle errors this way.
> Some applications like fuse-dfs need to handle the exit themselves after emitting an appropriate error message to its log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3963) libhdfs should never exit on its own but rather return errors to the calling application

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629146#action_12629146 ] 

Hudson commented on HADOOP-3963:
--------------------------------

Integrated in Hadoop-trunk #597 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/597/])

> libhdfs should never exit on its own but rather return errors to the calling application
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3963
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3963
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: libhdfs
>            Reporter: Pete Wyckoff
>            Assignee: Pete Wyckoff
>            Priority: Minor
>             Fix For: 0.19.0
>
>         Attachments: patch0.txt, patch1.txt
>
>
> A a library, libhdfs would be better to return errors rather than directly exiting. This way the calling application can determine what to do on error. And it is more unix library like to handle errors this way.
> Some applications like fuse-dfs need to handle the exit themselves after emitting an appropriate error message to its log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3963) libhdfs should never exit on its own but rather return errors to the calling application

Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pete Wyckoff updated HADOOP-3963:
---------------------------------

    Attachment: patch0.txt

> libhdfs should never exit on its own but rather return errors to the calling application
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3963
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3963
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: libhdfs
>            Reporter: Pete Wyckoff
>            Priority: Minor
>         Attachments: patch0.txt
>
>
> A a library, libhdfs would be better to return errors rather than directly exiting. This way the calling application can determine what to do on error. And it is more unix library like to handle errors this way.
> Some applications like fuse-dfs need to handle the exit themselves after emitting an appropriate error message to its log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3963) libhdfs should never exit on its own but rather return errors to the calling application

Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629003#action_12629003 ] 

Pete Wyckoff commented on HADOOP-3963:
--------------------------------------

no new tests because this is only when something is drastically wrong and in the current libhdfs environment that is almost impossible to test.  

The fact that the tests pass show that under normal conditions, everything is correct.

We could make libhdfs testing more robust be changing hdfs_test.c to testHdfs.java, but that's a bigger project.

Can someone please commit this as there 3 other pending libhdfs patches in the pipeline.

thanks, pete


> libhdfs should never exit on its own but rather return errors to the calling application
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3963
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3963
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: libhdfs
>            Reporter: Pete Wyckoff
>            Assignee: Pete Wyckoff
>            Priority: Minor
>             Fix For: 0.19.0
>
>         Attachments: patch0.txt, patch1.txt
>
>
> A a library, libhdfs would be better to return errors rather than directly exiting. This way the calling application can determine what to do on error. And it is more unix library like to handle errors this way.
> Some applications like fuse-dfs need to handle the exit themselves after emitting an appropriate error message to its log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3963) libhdfs should never exit on its own but rather return errors to the calling application

Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Chansler updated HADOOP-3963:
------------------------------------

    Release Note: 
Modified libhdfs to return NULL or error code when unrecoverable error occurs rather than exiting itself.


  was:
libhdfs modified to return NULL or error code when unrecoverable error occurs rather than exiting itself.


    Hadoop Flags: [Incompatible change, Reviewed]  (was: [Reviewed, Incompatible change])

> libhdfs should never exit on its own but rather return errors to the calling application
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3963
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3963
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: libhdfs
>            Reporter: Pete Wyckoff
>            Assignee: Pete Wyckoff
>            Priority: Minor
>             Fix For: 0.19.0
>
>         Attachments: patch0.txt, patch1.txt
>
>
> A a library, libhdfs would be better to return errors rather than directly exiting. This way the calling application can determine what to do on error. And it is more unix library like to handle errors this way.
> Some applications like fuse-dfs need to handle the exit themselves after emitting an appropriate error message to its log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3963) libhdfs should never exit on its own but rather return errors to the calling application

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628924#action_12628924 ] 

Hadoop QA commented on HADOOP-3963:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12389619/patch1.txt
  against trunk revision 692700.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3199/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3199/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3199/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3199/console

This message is automatically generated.

> libhdfs should never exit on its own but rather return errors to the calling application
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3963
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3963
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: libhdfs
>            Reporter: Pete Wyckoff
>            Assignee: Pete Wyckoff
>            Priority: Minor
>             Fix For: 0.19.0
>
>         Attachments: patch0.txt, patch1.txt
>
>
> A a library, libhdfs would be better to return errors rather than directly exiting. This way the calling application can determine what to do on error. And it is more unix library like to handle errors this way.
> Some applications like fuse-dfs need to handle the exit themselves after emitting an appropriate error message to its log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3963) libhdfs should never exit on its own but rather return errors to the calling application

Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pete Wyckoff updated HADOOP-3963:
---------------------------------

    Status: Patch Available  (was: Open)

> libhdfs should never exit on its own but rather return errors to the calling application
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3963
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3963
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: libhdfs
>            Reporter: Pete Wyckoff
>            Priority: Minor
>         Attachments: patch0.txt
>
>
> A a library, libhdfs would be better to return errors rather than directly exiting. This way the calling application can determine what to do on error. And it is more unix library like to handle errors this way.
> Some applications like fuse-dfs need to handle the exit themselves after emitting an appropriate error message to its log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3963) libhdfs should never exit on its own but rather return errors to the calling application

Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pete Wyckoff updated HADOOP-3963:
---------------------------------

    Assignee: Pete Wyckoff

> libhdfs should never exit on its own but rather return errors to the calling application
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3963
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3963
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: libhdfs
>            Reporter: Pete Wyckoff
>            Assignee: Pete Wyckoff
>            Priority: Minor
>         Attachments: patch0.txt
>
>
> A a library, libhdfs would be better to return errors rather than directly exiting. This way the calling application can determine what to do on error. And it is more unix library like to handle errors this way.
> Some applications like fuse-dfs need to handle the exit themselves after emitting an appropriate error message to its log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3963) libhdfs should never exit on its own but rather return errors to the calling application

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623529#action_12623529 ] 

Hadoop QA commented on HADOOP-3963:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12388337/patch0.txt
  against trunk revision 686893.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3067/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3067/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3067/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3067/console

This message is automatically generated.

> libhdfs should never exit on its own but rather return errors to the calling application
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3963
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3963
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: libhdfs
>            Reporter: Pete Wyckoff
>            Assignee: Pete Wyckoff
>            Priority: Minor
>         Attachments: patch0.txt
>
>
> A a library, libhdfs would be better to return errors rather than directly exiting. This way the calling application can determine what to do on error. And it is more unix library like to handle errors this way.
> Some applications like fuse-dfs need to handle the exit themselves after emitting an appropriate error message to its log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3963) libhdfs should never exit on its own but rather return errors to the calling application

Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pete Wyckoff updated HADOOP-3963:
---------------------------------

    Attachment: patch1.txt

addressed owen's comments.


> libhdfs should never exit on its own but rather return errors to the calling application
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3963
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3963
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: libhdfs
>            Reporter: Pete Wyckoff
>            Assignee: Pete Wyckoff
>            Priority: Minor
>         Attachments: patch0.txt, patch1.txt
>
>
> A a library, libhdfs would be better to return errors rather than directly exiting. This way the calling application can determine what to do on error. And it is more unix library like to handle errors this way.
> Some applications like fuse-dfs need to handle the exit themselves after emitting an appropriate error message to its log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3963) libhdfs should never exit on its own but rather return errors to the calling application

Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pete Wyckoff updated HADOOP-3963:
---------------------------------

    Status: Patch Available  (was: Open)

> libhdfs should never exit on its own but rather return errors to the calling application
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3963
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3963
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: libhdfs
>            Reporter: Pete Wyckoff
>            Assignee: Pete Wyckoff
>            Priority: Minor
>         Attachments: patch0.txt, patch1.txt
>
>
> A a library, libhdfs would be better to return errors rather than directly exiting. This way the calling application can determine what to do on error. And it is more unix library like to handle errors this way.
> Some applications like fuse-dfs need to handle the exit themselves after emitting an appropriate error message to its log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3963) libhdfs should never exit on its own but rather return errors to the calling application

Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

dhruba borthakur updated HADOOP-3963:
-------------------------------------

      Resolution: Fixed
    Hadoop Flags: [Incompatible change, Reviewed]  (was: [Incompatible change])
          Status: Resolved  (was: Patch Available)

I just committed this. Thanks Pete!

> libhdfs should never exit on its own but rather return errors to the calling application
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3963
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3963
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: libhdfs
>            Reporter: Pete Wyckoff
>            Assignee: Pete Wyckoff
>            Priority: Minor
>             Fix For: 0.19.0
>
>         Attachments: patch0.txt, patch1.txt
>
>
> A a library, libhdfs would be better to return errors rather than directly exiting. This way the calling application can determine what to do on error. And it is more unix library like to handle errors this way.
> Some applications like fuse-dfs need to handle the exit themselves after emitting an appropriate error message to its log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3963) libhdfs should never exit on its own but rather return errors to the calling application

Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pete Wyckoff updated HADOOP-3963:
---------------------------------

    Fix Version/s: 0.19.0

> libhdfs should never exit on its own but rather return errors to the calling application
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3963
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3963
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: libhdfs
>            Reporter: Pete Wyckoff
>            Assignee: Pete Wyckoff
>            Priority: Minor
>             Fix For: 0.19.0
>
>         Attachments: patch0.txt, patch1.txt
>
>
> A a library, libhdfs would be better to return errors rather than directly exiting. This way the calling application can determine what to do on error. And it is more unix library like to handle errors this way.
> Some applications like fuse-dfs need to handle the exit themselves after emitting an appropriate error message to its log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.