[jira] [Commented] (CASSANDRA-12997) dtest failure in org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName

["Aleksey Yeschenko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-12997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15804604#comment-15804604 ] 

Aleksey Yeschenko commented on CASSANDRA-12997:
-----------------------------------------------

TBH this feels just a tiny bit heavy-handed and not really fixing the issue (for cases with multiple nodes).

Nor do I think that this is a big issue to be fixed, in general. So the only real thing we should address here is the flakiness of the test.

For that I see two slightly simpler options:

1. (Uglier) Just use {{System.currentTimeMillis() + 1}} in {{AlterTableStatement}}
2. (Prettier) Now that we have CASSANDRA-7190, in the test itself pass explicit timestamp to {{ALTER TABLE DROP}} via {{USING TIMESTAMP}}, and do the same for inserts. This would make the test fully deterministic.

> dtest failure in org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-12997
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12997
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Sean McCarthy
>            Assignee: Sylvain Lebresne
>              Labels: test-failure, testall
>
> example failure:
> http://cassci.datastax.com/job/trunk_testall/1298/testReport/org.apache.cassandra.cql3.validation.operations/AlterTest/testDropListAndAddListWithSameName
> {code}
> Error Message
> Invalid value for row 0 column 2 (mycollection of type list<text>), expected <null> but got <[first element]>
> {code}{code}Stacktrace
> junit.framework.AssertionFailedError: Invalid value for row 0 column 2 (mycollection of type list<text>), expected <null> but got <[first element]>
> 	at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:908)
> 	at org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName(AlterTest.java:87)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)