You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2023/01/16 10:17:55 UTC
[GitHub] [maven-integration-testing] cstamas opened a new pull request, #236: [MNG-7667] Improve fix that cover m-p-p peculiarity
cstamas opened a new pull request, #236:
URL: https://github.com/apache/maven-integration-testing/pull/236
The m-p-p depends on m-p-tools-and and m-p-tools-beanshell as runtime/optional, and the way DownloadMojo resolves every artifacy causes that OptionalDependencySelector filter these out even at "collection" stage (as depth >= 2).
This is NOT happening while m-p-p resolved as plugin, as there m-p-p artifact POM is built and each dependency is being resolved (hence all the "depth levels" are shifted for -1).
Doing this in DownloadMojo would tremendously slow down the process, so adding a hack instead: when m-p-p is being resolved, we use "hack" session that omits OptionalDependencySelector.
---
https://issues.apache.org/jira/browse/MNG-7667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] cstamas commented on pull request #236: [MNG-7667] Improve fix that cover m-p-p peculiarity
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #236:
URL: https://github.com/apache/maven-integration-testing/pull/236#issuecomment-1383924049
Am redoing this, instead of hack make it proper, turns out reading POM is not such a big overhead (and is anyway done already as part of collection).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] cstamas merged pull request #236: [MNG-7667] Fix DownloadMojo to properly resolve
Posted by GitBox <gi...@apache.org>.
cstamas merged PR #236:
URL: https://github.com/apache/maven-integration-testing/pull/236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org