You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/25 10:16:00 UTC
[jira] [Commented] (FLINK-7257) Extend flink-runtime checkstyle
coverage to tests
[ https://issues.apache.org/jira/browse/FLINK-7257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099822#comment-16099822 ]
ASF GitHub Bot commented on FLINK-7257:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4394
[FLINK-7257] [runtime] Enable checkstyle for test files in flink-runtime
With this PR checkstyle rules are also applied to test sources in flink-runtime.
No packages for which we enabled checkstyle already was affected. For the remaining packages i either added an exclusion specifically for tests (same pattern introduced in #4384), or fixed the violations if there were only 1 or 2 anyway.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 7257
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4394.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4394
----
commit 832920acf2356aa4b05dd2455eb48c8986ae0628
Author: zentol <ch...@apache.org>
Date: 2017-07-24T14:28:51Z
[FLINK-7257] [runtime] Enable checkstyle for test files in flink-runtime
----
> Extend flink-runtime checkstyle coverage to tests
> -------------------------------------------------
>
> Key: FLINK-7257
> URL: https://issues.apache.org/jira/browse/FLINK-7257
> Project: Flink
> Issue Type: Improvement
> Components: Checkstyle
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Minor
> Fix For: 1.4.0
>
>
> Checkstyle is currently completely skipped for the test files in flink-runtime, which is not what i intended.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)