You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Rohini Palaniswamy <ro...@gmail.com> on 2014/11/03 18:08:22 UTC

Re: Review Request 27303: OOZIE-2035 NotificationXCommand should support proxy

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27303/#review59584
-----------------------------------------------------------


Once OOZIE-1890 goes in this patch will have to be rebased for Services.getConf()


core/src/main/java/org/apache/oozie/command/NotificationXCommand.java
<https://reviews.apache.org/r/27303/#comment100864>

    !proxyConf.trim().equals("")



core/src/main/java/org/apache/oozie/command/NotificationXCommand.java
<https://reviews.apache.org/r/27303/#comment100863>

    Remove WorkflowNotificationXCommand.



core/src/main/java/org/apache/oozie/command/coord/CoordActionNotificationXCommand.java
<https://reviews.apache.org/r/27303/#comment100861>

    This is missing in new loadState()



docs/src/site/twiki/CoordinatorFunctionalSpec.twiki
<https://reviews.apache.org/r/27303/#comment100865>

    =oozie.coord.action.notification.proxy= property can be used to configure either a http or socks proxy. The format is proxyHostname:port or proxyType@proxyHostname:port. If proxy type is not specified, it defaults to http. For eg: myhttpproxyhost.mydomain.com:80 or socks@mysockshost.mydomain.com:1080.
    
    Same to be copied for workflow.


- Rohini Palaniswamy


On Oct. 28, 2014, 8:46 p.m., Purshotam Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27303/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 8:46 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-2035
>     https://issues.apache.org/jira/browse/OOZIE-2035
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> NotificationXCommand should support proxy
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/oozie/client/OozieClient.java 5e53a18 
>   core/src/main/java/org/apache/oozie/command/NotificationXCommand.java e69de29 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionNotificationXCommand.java d220434 
>   core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 6073e4d 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 373c942 
>   core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 98fddfd 
>   core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java cac1381 
>   core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 73c1447 
>   core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 5ff0e5c 
>   core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 199af36 
>   core/src/main/java/org/apache/oozie/command/wf/WorkflowNotificationXCommand.java 73ce9a7 
>   core/src/main/resources/oozie-default.xml 26eb7e0 
>   core/src/test/java/org/apache/oozie/command/coord/TestCoordActionNotificationXCommand.java 7742dd4 
>   core/src/test/java/org/apache/oozie/command/wf/TestWorkflowNotificationXCommand.java b260747 
>   docs/src/site/twiki/CoordinatorFunctionalSpec.twiki adf4ae1 
>   docs/src/site/twiki/WorkflowFunctionalSpec.twiki e6e52a0 
> 
> Diff: https://reviews.apache.org/r/27303/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Purshotam Shah
> 
>