[c++] warning: race causing test to hang occasionally

[Gordon Sim <gs...@redhat.com>]

I noticed our cruisecontrolled build of the cpp trunk was blocked this 
morning. It turned out to be a test that failed to complete (perftest).

I couldn't reproduce it when running make check manually on the same 
box, but I saw the same thing again on the first attempt to restart 
cruisecontrol (a second attempt passed).

Its fairly hard to reproduce reliably, at least for me. Am investigating 
  further, so far without a great deal of success (unfortunately any 
logging or debug seems to mask the problem), but thought it was worth 
mentioning.

Re: [c++] warning: race causing test to hang occasionally

[Gordon Sim <gs...@redhat.com>]

Gordon Sim wrote:
> I noticed our cruisecontrolled build of the cpp trunk was blocked this 
> morning. It turned out to be a test that failed to complete (perftest).

I think I have found and fixed this (rev 576448). A flush request was 
not resulting in the credit being set to 0, there is also a race between 
the brokers dispatcher and the the flush handling thread so I've added 
some locking for that.