You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-commits@db.apache.org by be...@apache.org on 2005/11/24 21:51:34 UTC

svn commit: r348798 - in /db/derby/code/trunk/java: client/org/apache/derby/client/am/Cursor.java testing/org/apache/derbyTesting/functionTests/tests/lang/updatableResultSet.java

Author: bernt
Date: Thu Nov 24 12:51:18 2005
New Revision: 348798

URL: http://svn.apache.org/viewcvs?rev=348798&view=rev
Log:
DERBY-718 Network client: deleteRow() makes getter methods return nulls for the following rows. Submitted by Fernanda.Pizzorno@Sun.COM

Modified:
    db/derby/code/trunk/java/client/org/apache/derby/client/am/Cursor.java
    db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/updatableResultSet.java

Modified: db/derby/code/trunk/java/client/org/apache/derby/client/am/Cursor.java
URL: http://svn.apache.org/viewcvs/db/derby/code/trunk/java/client/org/apache/derby/client/am/Cursor.java?rev=348798&r1=348797&r2=348798&view=diff
==============================================================================
--- db/derby/code/trunk/java/client/org/apache/derby/client/am/Cursor.java (original)
+++ db/derby/code/trunk/java/client/org/apache/derby/client/am/Cursor.java Thu Nov 24 12:51:18 2005
@@ -141,6 +141,9 @@
 
         // mark the start of a new row.
         makeNextRowPositionCurrent();
+        
+        // Moving out of the hole, set isUpdateDeleteHole to false
+        isUpdateDeleteHole_ = false;
 
         // Drive the CNTQRY outside of calculateColumnOffsetsForRow() if the dataBuffer_
         // contains no data since it has no abilities to handle replies other than

Modified: db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/updatableResultSet.java
URL: http://svn.apache.org/viewcvs/db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/updatableResultSet.java?rev=348798&r1=348797&r2=348798&view=diff
==============================================================================
--- db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/updatableResultSet.java (original)
+++ db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/updatableResultSet.java Thu Nov 24 12:51:18 2005
@@ -879,6 +879,11 @@
 			}
       System.out.println("Position the ResultSet with next()");
 			rs.next();
+                        //Derby-718 check that column values are not null after next()
+                        if (rs.getInt(1) == 0) {
+                            System.out.println("First column should not be 0");
+                        }
+                        // Derby-718
       System.out.println("Should be able to deletRow() on the current row now");
 			rs.deleteRow();
 			//have to close the resultset because by default, resultsets are held open over commit
@@ -1031,6 +1036,11 @@
 			rs.next();
 			rs.deleteRow();
 			rs.next();
+                        //Derby-718 check that column values are not null after next()
+                        if (rs.getInt(1) == 0) {
+                            System.out.println("Column c21 should not be 0");
+                        }
+                        // Derby-718
 			rs.deleteRow();
 			System.out.println("As expected, no rows in temp table after deleteRow");
 			dumpRS(stmt.executeQuery("select * from SESSION.t2"));