[GitHub] [incubator-gobblin] htran1 commented on a change in pull request #2653: [GOBBLIN-787] Add an option to include the task start time in the out…

[GitBox <gi...@apache.org>]

htran1 commented on a change in pull request #2653: [GOBBLIN-787] Add an option to include the task start time in the out…
URL: https://github.com/apache/incubator-gobblin/pull/2653#discussion_r288682047
 
 

 ##########
 File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/fork/Fork.java
 ##########
 @@ -529,9 +529,18 @@ protected void cleanup() {
    */
   private DataWriter<Object> buildWriter()
       throws IOException {
+    String writerId = this.taskId;
+
+    // Add the task starting time if configured.
+    // This is used to reduce file name collisions which can happen due to the scheduling of a task on multiple workers.
+    // One case where this occurs is when a worker gets disconnected from a Helix cluster.
+    if (this.taskState.getPropAsBoolean(ConfigurationKeys.WRITER_ADD_TASK_TIMESTAMP, false)) {
+        writerId = this.taskId + "_" + this.taskState.getProp(ConfigurationKeys.TASK_START_TIME_MILLIS_KEY, "0");
 
 Review comment:
   Changed the code to raise an error if the task start time is not set as suggested by Shirshanka.
   The reason for using a fixed time assigned at task startup is to allow grouping of output files which can be useful to understand debug issues with task execution or to understand how much data comes from each task.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services