You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2022/04/13 08:13:59 UTC

[kudu-CR](gh-pages) Add .asf.yaml

Hello Andrew Wong,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/18410

to review the following change.


Change subject: Add .asf.yaml
......................................................................

Add .asf.yaml

An .asf.yaml was committed to the kudu-site repo from which the site
is published some time ago, but this is deleted when regenerating the
site from kudu/gh-pages. Adding this file in kudu/gh-pages should
resolve this issue.

Change-Id: I58d8f85e83ac2ad46d192abb58b748eb7bba6c98
---
A .asf.yaml
M _config.yml
2 files changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/18410/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newchange
Gerrit-Change-Id: I58d8f85e83ac2ad46d192abb58b748eb7bba6c98
Gerrit-Change-Number: 18410
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>

[kudu-CR](gh-pages) Add .asf.yaml

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18410 )

Change subject: Add .asf.yaml
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I58d8f85e83ac2ad46d192abb58b748eb7bba6c98
Gerrit-Change-Number: 18410
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Comment-Date: Thu, 28 Apr 2022 19:59:17 +0000
Gerrit-HasComments: No

[kudu-CR](gh-pages) Add .asf.yaml

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18410 )

Change subject: Add .asf.yaml
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I58d8f85e83ac2ad46d192abb58b748eb7bba6c98
Gerrit-Change-Number: 18410
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Comment-Date: Fri, 29 Apr 2022 10:47:11 +0000
Gerrit-HasComments: No

[kudu-CR](gh-pages) Add .asf.yaml

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18410 )

Change subject: Add .asf.yaml
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18410/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18410/1//COMMIT_MSG@7
PS1, Line 7: Add .asf.yaml
> +1
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I58d8f85e83ac2ad46d192abb58b748eb7bba6c98
Gerrit-Change-Number: 18410
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Comment-Date: Thu, 28 Apr 2022 19:13:12 +0000
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) Add .asf.yaml

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18410 )

Change subject: Add .asf.yaml
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18410/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18410/1//COMMIT_MSG@7
PS1, Line 7: Add .asf.yaml
Mind adding some context about what the file actually does and why it's important? Does something in the release process break?



-- 
To view, visit http://gerrit.cloudera.org:8080/18410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I58d8f85e83ac2ad46d192abb58b748eb7bba6c98
Gerrit-Change-Number: 18410
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Apr 2022 21:41:21 +0000
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) Add .asf.yaml

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18410 )

Change subject: Add .asf.yaml
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18410/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18410/1//COMMIT_MSG@7
PS1, Line 7: Add .asf.yaml
> Mind adding some context about what the file actually does and why it's imp
+1



-- 
To view, visit http://gerrit.cloudera.org:8080/18410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I58d8f85e83ac2ad46d192abb58b748eb7bba6c98
Gerrit-Change-Number: 18410
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Apr 2022 16:36:50 +0000
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) Add .asf.yaml

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18410 )

Change subject: Add .asf.yaml
......................................................................

Add .asf.yaml

An .asf.yaml was committed to the kudu-site repo from which the site
is published some time ago, but this is deleted when regenerating the
site from kudu/gh-pages. Adding this file in kudu/gh-pages should
resolve this issue.

This file is a config file required by the ASF infra[1], without it,
the updated site wouldn't be published.

[1] https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-WebsitedeploymentserviceforGitrepositories

Change-Id: I58d8f85e83ac2ad46d192abb58b748eb7bba6c98
Reviewed-on: http://gerrit.cloudera.org:8080/18410
Reviewed-by: Alexey Serbin <al...@apache.org>
Tested-by: Attila Bukor <ab...@apache.org>
---
A .asf.yaml
M _config.yml
2 files changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Attila Bukor: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: merged
Gerrit-Change-Id: I58d8f85e83ac2ad46d192abb58b748eb7bba6c98
Gerrit-Change-Number: 18410
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>

[kudu-CR](gh-pages) Add .asf.yaml

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Andrew Wong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18410

to look at the new patch set (#2).

Change subject: Add .asf.yaml
......................................................................

Add .asf.yaml

An .asf.yaml was committed to the kudu-site repo from which the site
is published some time ago, but this is deleted when regenerating the
site from kudu/gh-pages. Adding this file in kudu/gh-pages should
resolve this issue.

This file is a config file required by the ASF infra[1], without it,
the updated site wouldn't be published.

[1] https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-WebsitedeploymentserviceforGitrepositories

Change-Id: I58d8f85e83ac2ad46d192abb58b748eb7bba6c98
---
A .asf.yaml
M _config.yml
2 files changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/18410/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I58d8f85e83ac2ad46d192abb58b748eb7bba6c98
Gerrit-Change-Number: 18410
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>