You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2017/08/07 15:13:00 UTC
Review Request 61464: Added a test
`NamespacesIsolatorTest.ROOT_SharePidNamespace`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61464/
-----------------------------------------------------------
Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, and Vinod Kone.
Bugs: MESOS-7853
https://issues.apache.org/jira/browse/MESOS-7853
Repository: mesos
Description
-------
Added a test `NamespacesIsolatorTest.ROOT_SharePidNamespace`.
Diffs
-----
src/tests/containerizer/isolator_tests.cpp f3c541c92f8ecc5c12356363bbbf3561d3b75230
Diff: https://reviews.apache.org/r/61464/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 61464: Added a test
`NamespacesIsolatorTest.ROOT_SharePidNamespace`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61464/#review182751
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Aug. 7, 2017, 8:13 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61464/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2017, 8:13 a.m.)
>
>
> Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, and Vinod Kone.
>
>
> Bugs: MESOS-7853
> https://issues.apache.org/jira/browse/MESOS-7853
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `NamespacesIsolatorTest.ROOT_SharePidNamespace`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/isolator_tests.cpp f3c541c92f8ecc5c12356363bbbf3561d3b75230
>
>
> Diff: https://reviews.apache.org/r/61464/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 61464: Added a test
`NamespacesIsolatorTest.ROOT_SharePidNamespace`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61464/#review182750
-----------------------------------------------------------
src/tests/containerizer/isolator_tests.cpp
Lines 160-165 (patched)
<https://reviews.apache.org/r/61464/#comment258745>
I rephased a little bit:
```
// This test verifies a top-level container can share pid namespace
// with the agent when the field `share_pid_namespace` is set as
// 'true' in LinuxInfo. Please note that the agent flag
// `--disallow_sharing_agent_pid_namespace` is set to
// false by default, that means top-level container is allowed to share
// pid namespace with agent.
```
- Gilbert Song
On Aug. 7, 2017, 8:13 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61464/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2017, 8:13 a.m.)
>
>
> Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, and Vinod Kone.
>
>
> Bugs: MESOS-7853
> https://issues.apache.org/jira/browse/MESOS-7853
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `NamespacesIsolatorTest.ROOT_SharePidNamespace`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/isolator_tests.cpp f3c541c92f8ecc5c12356363bbbf3561d3b75230
>
>
> Diff: https://reviews.apache.org/r/61464/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 61464: Added a test
`NamespacesIsolatorTest.ROOT_SharePidNamespace`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61464/
-----------------------------------------------------------
(Updated Aug. 14, 2017, 10:03 a.m.)
Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, and Vinod Kone.
Changes
-------
Addressed comments.
Bugs: MESOS-7853
https://issues.apache.org/jira/browse/MESOS-7853
Repository: mesos
Description
-------
Added a test `NamespacesIsolatorTest.ROOT_SharePidNamespace`.
Diffs (updated)
-----
src/tests/containerizer/isolator_tests.cpp f3c541c92f8ecc5c12356363bbbf3561d3b75230
Diff: https://reviews.apache.org/r/61464/diff/2/
Changes: https://reviews.apache.org/r/61464/diff/1-2/
Testing
-------
Thanks,
Qian Zhang