[GitHub] [camel-k] squakez commented on a diff in pull request #4353: fix(#4336): Restrict Knative binding provider execution for v1alpha1

["squakez (via GitHub)" <gi...@apache.org>]

squakez commented on code in PR #4353:
URL: https://github.com/apache/camel-k/pull/4353#discussion_r1189487856


##########
pkg/util/bindings/knative_ref.go:
##########
@@ -150,6 +150,17 @@ func (k V1alpha1KnativeRefBindingProvider) Translate(ctx V1alpha1BindingContext,
 		return nil, nil
 	}
 
+	if ok, err := isKnownKnativeResource(e.Ref); !ok {

Review Comment:
   This change is done on the `V1alpha1KnativeRefBindingProvider` only. I think we need this for the new `KnativeRefBindingProvider` as well (the former is the one used for deprecated `KameletBinding`).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org