You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <an...@apache.org> on 2017/08/02 17:56:41 UTC
Re: Review Request 60508: Fixed Attributes comparison.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60508/#review182010
-----------------------------------------------------------
Fix it, then Ship it!
Looks good, just some minor comments.
include/mesos/v1/attributes.hpp
Lines 95 (patched)
<https://reviews.apache.org/r/60508/#comment257822>
Can we add a comment for posterity on the usage of `contains` and how does it differ from `get()`?
src/v1/attributes.cpp
Lines 98 (patched)
<https://reviews.apache.org/r/60508/#comment257821>
Missing indent.
- Anand Mazumdar
On July 26, 2017, 4:46 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60508/
> -----------------------------------------------------------
>
> (Updated July 26, 2017, 4:46 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-1216
> https://issues.apache.org/jira/browse/MESOS-1216
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently we don't enforce attribute name uniqueness. But the comparison
> operator for `Attributes` expects that attribute name and type are
> unique. This causes causes agent recovery failure.
>
> This fixes the issue by allowing multiple attributes of same name and
> type.
>
>
> Diffs
> -----
>
> include/mesos/attributes.hpp 641febbd3bc3700b2c088f4388d8e6f18e6b078a
> include/mesos/v1/attributes.hpp 022bfde430c618708843a4d790f3f8a118ae082b
> src/common/attributes.cpp ac683c7fe5b67fb8a73599230a3eb47911293a7e
> src/tests/attributes_tests.cpp cb71be5ecead322d90943146f54f8a0c915eba1c
> src/v1/attributes.cpp 409d66453c492a329adc4e16312924e21a6d4709
>
>
> Diff: https://reviews.apache.org/r/60508/diff/1/
>
>
> Testing
> -------
>
> Added a test to `AttributesTest.Equality`. Ran `make check`. Verified manually by failing over the agent with multiple attributes with the same name.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 60508: Fixed Attributes comparison.
Posted by Ilya Pronin <ip...@twopensource.com>.
> On Aug. 2, 2017, 6:56 p.m., Anand Mazumdar wrote:
> > include/mesos/v1/attributes.hpp
> > Lines 95 (patched)
> > <https://reviews.apache.org/r/60508/diff/1/?file=1766370#file1766370line95>
> >
> > Can we add a comment for posterity on the usage of `contains` and how does it differ from `get()`?
Done. Added comments for `contains()` and `get()` methods describing what they do.
- Ilya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60508/#review182010
-----------------------------------------------------------
On Aug. 3, 2017, 1:11 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60508/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2017, 1:11 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-1216
> https://issues.apache.org/jira/browse/MESOS-1216
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently we don't enforce attribute name uniqueness. But the comparison
> operator for `Attributes` expects that attribute name and type are
> unique. This causes causes agent recovery failure.
>
> This fixes the issue by allowing multiple attributes of same name and
> type.
>
>
> Diffs
> -----
>
> include/mesos/attributes.hpp 641febbd3bc3700b2c088f4388d8e6f18e6b078a
> include/mesos/v1/attributes.hpp 022bfde430c618708843a4d790f3f8a118ae082b
> src/common/attributes.cpp ac683c7fe5b67fb8a73599230a3eb47911293a7e
> src/tests/attributes_tests.cpp cb71be5ecead322d90943146f54f8a0c915eba1c
> src/v1/attributes.cpp 409d66453c492a329adc4e16312924e21a6d4709
>
>
> Diff: https://reviews.apache.org/r/60508/diff/2/
>
>
> Testing
> -------
>
> Added a test to `AttributesTest.Equality`. Ran `make check`. Verified manually by failing over the agent with multiple attributes with the same name.
>
>
> Thanks,
>
> Ilya Pronin
>
>