You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by iv...@apache.org on 2007/04/11 20:16:44 UTC
svn commit: r527595 -
/incubator/wicket/branches/wicket-1.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/parser/filter/WicketTagIdentifier.java
Author: ivaynberg
Date: Wed Apr 11 11:16:44 2007
New Revision: 527595
URL: http://svn.apache.org/viewvc?view=rev&rev=527595
Log:
who thought it was a good idea to do "wicket"->"org.apache.wicket" ????
Modified:
incubator/wicket/branches/wicket-1.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/parser/filter/WicketTagIdentifier.java
Modified: incubator/wicket/branches/wicket-1.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/parser/filter/WicketTagIdentifier.java
URL: http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/parser/filter/WicketTagIdentifier.java?view=diff&rev=527595&r1=527594&r2=527595
==============================================================================
--- incubator/wicket/branches/wicket-1.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/parser/filter/WicketTagIdentifier.java (original)
+++ incubator/wicket/branches/wicket-1.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/parser/filter/WicketTagIdentifier.java Wed Apr 11 11:16:44 2007
@@ -122,8 +122,7 @@
"The wicket:id attribute value must not be empty. May be unmatched quotes?!?",
tag.getPos());
}
- // Make it a org.apache.wicket component. Otherwise it would be
- // RawMarkup
+ // Make it a wicket component. Otherwise it would be RawMarkup
tag.setId(value);
}
Re: "org.apache.wicket"->"wicket"
Posted by Eelco Hillenius <ee...@gmail.com>.
Cheers,
Eelco
On 4/12/07, Jean-Baptiste Quenot <jb...@apache.org> wrote:
> OK, cleanup done, but we need to double-check the YUI JavaScript
> stuff that must stay "wicket".
> --
> Jean-Baptiste Quenot
> aka John Banana Qwerty
> http://caraldi.com/jbq/
>
Re: "org.apache.wicket"->"wicket"
Posted by Jean-Baptiste Quenot <jb...@apache.org>.
OK, cleanup done, but we need to double-check the YUI JavaScript
stuff that must stay "wicket".
--
Jean-Baptiste Quenot
aka John Banana Qwerty
http://caraldi.com/jbq/
Re: "wicket"->"org.apache.wicket"
Posted by Johan Compagner <jc...@gmail.com>.
that should stay "wicket"
see DatePicker itself, that one was already reverted/fixed again.
johan
On 4/12/07, Jean-Baptiste Quenot <jb...@apache.org> wrote:
>
> * Johan Compagner:
> > yes
> >
> > the biggest problem and i could solve this easy if i had catched it a
> bit
> > earlier
> > is that we have (or had i think eelco cleaned that up)
> >
> > "org.apache.wicket:"
> >
> > all those strings should be replaced with just "wicket:" because those
> where
> > the "wicket:panel" or "wicket:component"
>
> I'm doing some cleanup with a magic command and came across a
> strange thing:
>
> ./jdk-1.4
> /wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DatePicker.java
>
> buffer.append("YAHOO.namespace(\"wicket\");\nfunction init");
>
> ./jdk-1.4
> /wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/AbstractCalendar.java
>
> b.append("YAHOO.namespace(\"org.apache.wicket\");\nfunction init");
>
> Which namespace is right?
> --
> Jean-Baptiste Quenot
> aka John Banana Qwerty
> http://caraldi.com/jbq/
>
Re: "wicket"->"org.apache.wicket"
Posted by Jean-Baptiste Quenot <jb...@apache.org>.
* Johan Compagner:
> yes
>
> the biggest problem and i could solve this easy if i had catched it a bit
> earlier
> is that we have (or had i think eelco cleaned that up)
>
> "org.apache.wicket:"
>
> all those strings should be replaced with just "wicket:" because those where
> the "wicket:panel" or "wicket:component"
I'm doing some cleanup with a magic command and came across a
strange thing:
./jdk-1.4/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DatePicker.java
buffer.append("YAHOO.namespace(\"wicket\");\nfunction init");
./jdk-1.4/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/AbstractCalendar.java
b.append("YAHOO.namespace(\"org.apache.wicket\");\nfunction init");
Which namespace is right?
--
Jean-Baptiste Quenot
aka John Banana Qwerty
http://caraldi.com/jbq/
Re: "wicket"->"org.apache.wicket"
Posted by Johan Compagner <jc...@gmail.com>.
yes
the biggest problem and i could solve this easy if i had catched it a bit
earlier
is that we have (or had i think eelco cleaned that up)
"org.apache.wicket:"
all those strings should be replaced with just "wicket:" because those where
the "wicket:panel" or "wicket:component"
johan
On 4/12/07, Jean-Baptiste Quenot <jb...@apache.org> wrote:
>
> * Johan Compagner:
> > of course it should be on the javadoc.
> > of course it should be on many properties files (wicket.properties, log
> > properties)
> > of course it should be on web.xml file
> > of course it also should be on many html files (bookmarkable pages,
> things
> > like class="wicket.my.component", "resource/wicket.xxx")
>
> Indeed, I understand. And I guess it's pretty hard to guess if it
> is a word or a Java class name? Unless you do some regular
> expression magic, to have at least a dot after "wicket" and then
> another word.
>
> So the only solution now is to do the reverse and search for
> org.apache.wicket *not* followed by a dot and a word.
> --
> Jean-Baptiste Quenot
> aka John Banana Qwerty
> http://caraldi.com/jbq/
>
Re: "wicket"->"org.apache.wicket"
Posted by Jean-Baptiste Quenot <jb...@apache.org>.
* Johan Compagner:
> of course it should be on the javadoc.
> of course it should be on many properties files (wicket.properties, log
> properties)
> of course it should be on web.xml file
> of course it also should be on many html files (bookmarkable pages, things
> like class="wicket.my.component", "resource/wicket.xxx")
Indeed, I understand. And I guess it's pretty hard to guess if it
is a word or a Java class name? Unless you do some regular
expression magic, to have at least a dot after "wicket" and then
another word.
So the only solution now is to do the reverse and search for
org.apache.wicket *not* followed by a dot and a word.
--
Jean-Baptiste Quenot
aka John Banana Qwerty
http://caraldi.com/jbq/
Re: "wicket"->"org.apache.wicket"
Posted by Johan Compagner <jc...@gmail.com>.
of course it should be on the javadoc.
of course it should be on many properties files (wicket.properties, log
properties)
of course it should be on web.xml file
of course it also should be on many html files (bookmarkable pages, things
like class="wicket.my.component", "resource/wicket.xxx")
So the problem is that many things should happen and many things shouldn't
happen.
but js files should be ignored, i didn't touch them as far as i know.
johan
On 4/12/07, Jean-Baptiste Quenot <jb...@apache.org> wrote:
>
> * ivaynberg@apache.org:
> > Author: ivaynberg
> > Date: Wed Apr 11 11:16:44 2007
> > New Revision: 527595
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=527595
> > Log:
> > who thought it was a good idea to do "wicket"->"org.apache.wicket" ????
>
> Indeed I expected that only to happen on Java classes, not on any
> string, like JS libraries, Javadoc... What went wrong?
> --
> Jean-Baptiste Quenot
> aka John Banana Qwerty
> http://caraldi.com/jbq/
>
Re: "wicket"->"org.apache.wicket"
Posted by Jean-Baptiste Quenot <jb...@apache.org>.
* ivaynberg@apache.org:
> Author: ivaynberg
> Date: Wed Apr 11 11:16:44 2007
> New Revision: 527595
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=527595
> Log:
> who thought it was a good idea to do "wicket"->"org.apache.wicket" ????
Indeed I expected that only to happen on Java classes, not on any
string, like JS libraries, Javadoc... What went wrong?
--
Jean-Baptiste Quenot
aka John Banana Qwerty
http://caraldi.com/jbq/