You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/07/26 07:29:13 UTC
[GitHub] [mynewt-core] kasjer opened a new pull request #2644: hw/bus/spi_hal: Fix bus_spi_write_read
kasjer opened a new pull request #2644:
URL: https://github.com/apache/mynewt-core/pull/2644
Function bus_spi_write_read() was calling hal_spi_txrx()
with NULL for txbuf for transactions involving more then 16 bytes.
NULL pointer is not valid for this function.
When code was build with SPI_HAL_USE_NOBLOCK enabled, zeroed receive buffer
was already used as argument for transmit buffer.
Same approach is now used when SPI_HAL_USE_NOBLOCK is not set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane merged pull request #2644: hw/bus/spi_hal: Fix bus_spi_write_read
Posted by GitBox <gi...@apache.org>.
vrahane merged pull request #2644:
URL: https://github.com/apache/mynewt-core/pull/2644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] kasjer commented on pull request #2644: hw/bus/spi_hal: Fix bus_spi_write_read
Posted by GitBox <gi...@apache.org>.
kasjer commented on pull request #2644:
URL: https://github.com/apache/mynewt-core/pull/2644#issuecomment-886498470
> To be consistent with:
>
> https://github.com/apache/mynewt-core/blob/ca3280bcd39b1dc44df307db27f243c9a3b39ab7/hw/bus/drivers/spi_hal/src/spi_hal.c#L145
>
> the memset should probably be setting it to 0xFF instead of 0?
@ncasaril thanks for pointing out inconsistency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] ncasaril commented on pull request #2644: hw/bus/spi_hal: Fix bus_spi_write_read
Posted by GitBox <gi...@apache.org>.
ncasaril commented on pull request #2644:
URL: https://github.com/apache/mynewt-core/pull/2644#issuecomment-886505566
I've now tested this change on nrf52 working with large reads / writes to a spi device (dw1000).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] ncasaril commented on pull request #2644: hw/bus/spi_hal: Fix bus_spi_write_read
Posted by GitBox <gi...@apache.org>.
ncasaril commented on pull request #2644:
URL: https://github.com/apache/mynewt-core/pull/2644#issuecomment-886500719
This will work for me and as you pointed out it has fewer repercussions than having to update the hal_spi_txrx for all mcus. I'll withdraw PR #2643 in favour of this one. Thanks @kasjer!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org