[GitHub] [nifi-minifi] shonzilla commented on issue #161: MINIFI-504 Upgrade commons-daemon & fix the build

[GitBox <gi...@apache.org>]

shonzilla commented on issue #161: MINIFI-504 Upgrade commons-daemon & fix the build
URL: https://github.com/apache/nifi-minifi/pull/161#issuecomment-510013680
 
 
   Hi @apiri. You surely meant #157 that you have already submitted and it went under my radar. (facepalm)
   
   I'm not sure what exactly you mean with your question:
   > Would it be sufficient for you to merge that update (locally scoped property for the full filename in this PR #161) in with my PR (#151 ) out there and use that as the resultant fix?
   
   AFAICT the Git repository has a linear history (which I like) so with "merge" you surely do not refer to a " Git merge". Therefore I believe you're asking I'm fine with you adopting my minor improvement into your PR. Is that correct?
   Generally I'm perfectly fine with that although I personally prefer more focused commits (i.e. would have done digest algorithm change a separate commit) and I was hoping getting this PR merge into master and slowly getting more active on GitHub, starting with MiNiFi I was intending to use for a prototype after being a happy NiFi user. 😊
    

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services