You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by sr...@apache.org on 2018/07/20 18:29:25 UTC

flink git commit: [hotfix] Fix loop in FailingSource

Repository: flink
Updated Branches:
  refs/heads/master 0b4947b61 -> f60aa6e72


[hotfix] Fix loop in FailingSource


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/f60aa6e7
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/f60aa6e7
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/f60aa6e7

Branch: refs/heads/master
Commit: f60aa6e72ca860bb30730472c0c7db8fef500e5c
Parents: 0b4947b
Author: Stefan Richter <s....@data-artisans.com>
Authored: Fri Jul 20 20:28:55 2018 +0200
Committer: Stefan Richter <s....@data-artisans.com>
Committed: Fri Jul 20 20:28:55 2018 +0200

----------------------------------------------------------------------
 .../org/apache/flink/test/checkpointing/utils/FailingSource.java  | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/f60aa6e7/flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/FailingSource.java
----------------------------------------------------------------------
diff --git a/flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/FailingSource.java b/flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/FailingSource.java
index 822d73b..ff49959 100644
--- a/flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/FailingSource.java
+++ b/flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/FailingSource.java
@@ -98,12 +98,11 @@ public class FailingSource extends RichSourceFunction<Tuple2<Long, IntType>>
 
 		// we loop longer than we have elements, to permit delayed checkpoints
 		// to still cause a failure
-		while (running) {
+		while (running && emitCallCount < expectedEmitCalls) {
 
 			// the function failed before, or we are in the elements before the failure
 			synchronized (ctx.getCheckpointLock()) {
 				eventEmittingGenerator.emitEvent(ctx, emitCallCount++);
-				running &= (emitCallCount < expectedEmitCalls);
 			}
 
 			if (emitCallCount < failureAfterNumElements) {