You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2020/01/17 06:07:11 UTC
[GitHub] [dubbo] codecov-io commented on issue #5356: optimize : constant names should be all uppercase, separated by underscores

# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5356?src=pr&el=h1) Report
> Merging [#5356](https://codecov.io/gh/apache/dubbo/pull/5356?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo/commit/3e7bc863379407df1d640d84cbe028f01bcec832?src=pr&el=desc) will **increase** coverage by `0.17%`.
> The diff coverage is `70.49%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/5356/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/dubbo/pull/5356?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #5356      +/-   ##
============================================
+ Coverage     61.02%   61.19%   +0.17%     
  Complexity      421      421              
============================================
  Files           919      923       +4     
  Lines         37499    37568      +69     
  Branches       5446     5441       -5     
============================================
+ Hits          22884    22991     +107     
+ Misses        12119    12082      -37     
+ Partials       2496     2495       -1
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5356?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...main/java/org/apache/dubbo/remoting/Constants.java](https://codecov.io/gh/apache/dubbo/pull/5356/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9Db25zdGFudHMuamF2YQ==) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...bbo/rpc/proxy/javassist/JavassistProxyFactory.java](https://codecov.io/gh/apache/dubbo/pull/5356/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm94eS9qYXZhc3Npc3QvSmF2YXNzaXN0UHJveHlGYWN0b3J5LmphdmE=) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...bo/rpc/cluster/interceptor/ClusterInterceptor.java](https://codecov.io/gh/apache/dubbo/pull/5356/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvaW50ZXJjZXB0b3IvQ2x1c3RlckludGVyY2VwdG9yLmphdmE=) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...a/org/apache/dubbo/config/ConfigPostProcessor.java](https://codecov.io/gh/apache/dubbo/pull/5356/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Db25maWdQb3N0UHJvY2Vzc29yLmphdmE=) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java](https://codecov.io/gh/apache/dubbo/pull/5356/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvUHJvdG9jb2wuamF2YQ==) | `61.5% <ø> (-2.3%)` | `0 <0> (ø)` | |
| [...ava/org/apache/dubbo/config/ConfigInitializer.java](https://codecov.io/gh/apache/dubbo/pull/5356/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Db25maWdJbml0aWFsaXplci5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...api/src/main/java/org/apache/dubbo/rpc/Filter.java](https://codecov.io/gh/apache/dubbo/pull/5356/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9GaWx0ZXIuamF2YQ==) | `100% <ø> (+100%)` | `0 <0> (ø)` | :arrow_down: |
| [...che/dubbo/common/compiler/support/JdkCompiler.java](https://codecov.io/gh/apache/dubbo/pull/5356/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29tcGlsZXIvc3VwcG9ydC9KZGtDb21waWxlci5qYXZh) | `63.2% <ø> (-1.34%)` | `0 <0> (ø)` | |
| [...org/apache/dubbo/config/AbstractServiceConfig.java](https://codecov.io/gh/apache/dubbo/pull/5356/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RTZXJ2aWNlQ29uZmlnLmphdmE=) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/dubbo/pull/5356/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvZXh0ZW5zaW9uL1NwcmluZ0V4dGVuc2lvbkZhY3RvcnkuamF2YQ==) | `90.47% <ø> (-2.39%)` | `0 <0> (ø)` | |
| ... and [100 more](https://codecov.io/gh/apache/dubbo/pull/5356/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/5356?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/5356?src=pr&el=footer). Last update [3e7bc86...782c602](https://codecov.io/gh/apache/dubbo/pull/5356?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo/pull/5356 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org