[GitHub] [incubator-devlake] mintsweet commented on a diff in pull request #3153: refactor: update eslint configuration + run eslint

[GitBox <gi...@apache.org>]

mintsweet commented on code in PR #3153:
URL: https://github.com/apache/incubator-devlake/pull/3153#discussion_r975963830


##########
config-ui/.prettierrc.js:
##########
@@ -17,9 +17,15 @@
  */
 
 module.exports = {
-  printWidth: 140,
+  printWidth: 80,
   singleQuote: true,
+  singleAttributePerLine: false,

Review Comment:
   the same `useTabs`, `tabWidth`,  `bracketSameLine`, `arrowParens`  



##########
config-ui/.eslintrc:
##########
@@ -49,8 +55,22 @@
   "rules": {
     "prettier/prettier": ["warn"],
     "camelcase": "off",
+    "semi": ["error", "never"],
     "max-len": [1, 140, 2],

Review Comment:
   The maximum length of the prettier has changed, should it be modified here too?



##########
config-ui/.prettierrc.js:
##########
@@ -17,9 +17,15 @@
  */
 
 module.exports = {
-  printWidth: 140,
+  printWidth: 80,
   singleQuote: true,
+  singleAttributePerLine: false,

Review Comment:
   false should be the default value of this property, is it not necessary to add this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org