You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ho...@apache.org on 2012/06/05 20:04:25 UTC

svn commit: r1346500 - in /lucene/dev/trunk/solr/core/src: test-files/solr/conf/solrconfig-transformers.xml test/org/apache/solr/update/processor/UpdateRequestProcessorFactoryTest.java

Author: hossman
Date: Tue Jun  5 18:04:25 2012
New Revision: 1346500

URL: http://svn.apache.org/viewvc?rev=1346500&view=rev
Log:
SOLR-3095: improve test to demo/verify that enable=false works on update processors

Modified:
    lucene/dev/trunk/solr/core/src/test-files/solr/conf/solrconfig-transformers.xml
    lucene/dev/trunk/solr/core/src/test/org/apache/solr/update/processor/UpdateRequestProcessorFactoryTest.java

Modified: lucene/dev/trunk/solr/core/src/test-files/solr/conf/solrconfig-transformers.xml
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/test-files/solr/conf/solrconfig-transformers.xml?rev=1346500&r1=1346499&r2=1346500&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/test-files/solr/conf/solrconfig-transformers.xml (original)
+++ lucene/dev/trunk/solr/core/src/test-files/solr/conf/solrconfig-transformers.xml Tue Jun  5 18:04:25 2012
@@ -26,6 +26,13 @@
 
 
 <updateRequestProcessorChain name="standard">
+  <processor class="solr.CustomUpdateRequestProcessorFactory" enable="false">
+   <!-- this processor is not enabled, so it won't be used at all -->
+   <lst name="name">
+     <str name="n1">x1</str>
+     <str name="n2">x2</str>
+   </lst>
+  </processor>
   <processor class="solr.LogUpdateProcessorFactory" >
    <int name="maxNumToLog">100</int>
   </processor>

Modified: lucene/dev/trunk/solr/core/src/test/org/apache/solr/update/processor/UpdateRequestProcessorFactoryTest.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/test/org/apache/solr/update/processor/UpdateRequestProcessorFactoryTest.java?rev=1346500&r1=1346499&r2=1346500&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/test/org/apache/solr/update/processor/UpdateRequestProcessorFactoryTest.java (original)
+++ lucene/dev/trunk/solr/core/src/test/org/apache/solr/update/processor/UpdateRequestProcessorFactoryTest.java Tue Jun  5 18:04:25 2012
@@ -43,10 +43,17 @@ public class UpdateRequestProcessorFacto
     // make sure it loaded the factories
     UpdateRequestProcessorChain chained = core.getUpdateProcessingChain( "standard" );
     
-    // Make sure it got 3 items and configured the Log chain ok
-    assertEquals( 3, chained.getFactories().length );
-    LogUpdateProcessorFactory log = (LogUpdateProcessorFactory)chained.getFactories()[0];
-    assertEquals( 100, log.maxNumToLog );
+    // Make sure it got 3 items (4 configured, 1 is enable=false)
+    assertEquals("wrong number of (enabled) factories in chain",
+                 3, chained.getFactories().length );
+
+    // first one should be log, and it should be configured properly
+    UpdateRequestProcessorFactory first = chained.getFactories()[0];
+    assertEquals("wrong factory at front of chain",
+                 LogUpdateProcessorFactory.class, first.getClass());
+    LogUpdateProcessorFactory log = (LogUpdateProcessorFactory)first;
+    assertEquals("wrong config for LogUpdateProcessorFactory",
+                 100, log.maxNumToLog );
     
     
     UpdateRequestProcessorChain custom = core.getUpdateProcessingChain( null );