You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "sohardforaname (via GitHub)" <gi...@apache.org> on 2023/08/21 07:17:35 UTC
[GitHub] [doris] sohardforaname opened a new pull request, #23249: [Fix](Nereids)add nereids load function in read fields of GlobalFunctionMgr and Database for branch-2.0
sohardforaname opened a new pull request, #23249:
URL: https://github.com/apache/doris/pull/23249
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
add nereids load function in read fields of GlobalFunctionMgr and Database to fix some udf is lost when restart FE and
query with Nereids.
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xiaokang merged pull request #23249: [Fix](Nereids)add nereids load function in read fields of GlobalFunctionMgr and Database
Posted by "xiaokang (via GitHub)" <gi...@apache.org>.
xiaokang merged PR #23249:
URL: https://github.com/apache/doris/pull/23249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] sohardforaname commented on pull request #23249: [Fix](Nereids)add nereids load function in read fields of GlobalFunctionMgr and Database
Posted by "sohardforaname (via GitHub)" <gi...@apache.org>.
sohardforaname commented on PR #23249:
URL: https://github.com/apache/doris/pull/23249#issuecomment-1687680733
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] sohardforaname commented on pull request #23249: [Fix](Nereids)add nereids load function in read fields of GlobalFunctionMgr and Database
Posted by "sohardforaname (via GitHub)" <gi...@apache.org>.
sohardforaname commented on PR #23249:
URL: https://github.com/apache/doris/pull/23249#issuecomment-1689547761
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #23249: [Fix](Nereids)add nereids load function in read fields of GlobalFunctionMgr and Database
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #23249:
URL: https://github.com/apache/doris/pull/23249#discussion_r1300856712
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionUtil.java:
##########
@@ -234,8 +239,11 @@ public static boolean translateToNereids(String dbName, Function function) {
JavaUdaf.translateToNereidsFunction(dbName, ((AggregateFunction) function));
}
} catch (Exception e) {
- LOG.warn("Nereids create function {}:{} failed", dbName, function.getFunctionName().getFunction(), e);
+ LOG.warn("Nereids create function {}:{} failed, caused by: {}", dbName == null ? "_global_" : dbName,
+ function.getFunctionName().getFunction(), e);
}
+ LOG.info(String.format("Nereids add function: %s:%s OK!", dbName == null ? "_global_" : dbName,
+ function.getFunctionName().getFunction()));
Review Comment:
remove this log
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionUtil.java:
##########
@@ -246,8 +254,11 @@ public static boolean dropFromNereids(String dbName, FunctionSearchDesc function
.collect(Collectors.toList());
Env.getCurrentEnv().getFunctionRegistry().dropUdf(dbName, fnName, argTypes);
} catch (Exception e) {
- LOG.warn("Nereids drop function {}:{} failed", dbName, function.getName(), e);
+ LOG.warn("Nereids drop function {}:{} failed, caused by: {}", dbName == null ? "_global_" : dbName,
+ function.getName(), e);
}
+ LOG.info(String.format("Nereids drop function: %s:%s OK!", dbName == null ? "_global_" : dbName,
+ function.getName()));
Review Comment:
remove this log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] sohardforaname commented on pull request #23249: [Fix](Nereids)add nereids load function in read fields of GlobalFunctionMgr and Database for branch-2.0
Posted by "sohardforaname (via GitHub)" <gi...@apache.org>.
sohardforaname commented on PR #23249:
URL: https://github.com/apache/doris/pull/23249#issuecomment-1685782355
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #23249: [Fix](Nereids)add nereids load function in read fields of GlobalFunctionMgr and Database for branch-2.0
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #23249:
URL: https://github.com/apache/doris/pull/23249#issuecomment-1685826530
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.54 seconds
stream load tsv: 547 seconds loaded 74807831229 Bytes, about 130 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size: 17164544632 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #23249: [Fix](Nereids)add nereids load function in read fields of GlobalFunctionMgr and Database
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #23249:
URL: https://github.com/apache/doris/pull/23249#issuecomment-1687796467
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.26 seconds
stream load tsv: 549 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.6 seconds inserted 10000000 Rows, about 337K ops/s
storage size: 17162785668 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #23249: [Fix](Nereids)add nereids load function in read fields of GlobalFunctionMgr and Database
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23249:
URL: https://github.com/apache/doris/pull/23249#issuecomment-1689476929
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #23249: [Fix](Nereids)add nereids load function in read fields of GlobalFunctionMgr and Database
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #23249:
URL: https://github.com/apache/doris/pull/23249#issuecomment-1689384534
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.49 seconds
stream load tsv: 547 seconds loaded 74807831229 Bytes, about 130 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.7 seconds inserted 10000000 Rows, about 336K ops/s
storage size: 17162220219 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] sohardforaname commented on pull request #23249: [Fix](Nereids)add nereids load function in read fields of GlobalFunctionMgr and Database
Posted by "sohardforaname (via GitHub)" <gi...@apache.org>.
sohardforaname commented on PR #23249:
URL: https://github.com/apache/doris/pull/23249#issuecomment-1689350278
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #23249: [Fix](Nereids)add nereids load function in read fields of GlobalFunctionMgr and Database
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23249:
URL: https://github.com/apache/doris/pull/23249#issuecomment-1689476988
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org