You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexei Fedotov (JIRA)" <ji...@apache.org> on 2008/02/17 11:52:34 UTC

[jira] Created: (HARMONY-5521) [build] fix incremental federated build

[build] fix incremental federated build
---------------------------------------

                 Key: HARMONY-5521
                 URL: https://issues.apache.org/jira/browse/HARMONY-5521
             Project: Harmony
          Issue Type: Improvement
          Components: build - test - ci
            Reporter: Alexei Fedotov


This is a patch which enables incremental Harmony build via conventional federated build option "build". Testing changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5521) [build] fix incremental federated build

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov updated HARMONY-5521:
------------------------------------

    Attachment: incremental_build_1.patch

The patch which renames "default" target and sets a default build target to "build".

> [build] fix incremental federated build
> ---------------------------------------
>
>                 Key: HARMONY-5521
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5521
>             Project: Harmony
>          Issue Type: Improvement
>          Components: build - test - ci
>            Reporter: Alexei Fedotov
>            Assignee: Pavel Pervov
>         Attachments: incremental_build.patch, incremental_build_1.patch
>
>
> This is a patch which enables incremental Harmony build via conventional federated build option "build". Testing changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-5521) [build] fix incremental federated build

Posted by "Pavel Pervov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pavel Pervov reassigned HARMONY-5521:
-------------------------------------

    Assignee: Pavel Pervov

> [build] fix incremental federated build
> ---------------------------------------
>
>                 Key: HARMONY-5521
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5521
>             Project: Harmony
>          Issue Type: Improvement
>          Components: build - test - ci
>            Reporter: Alexei Fedotov
>            Assignee: Pavel Pervov
>         Attachments: incremental_build.patch
>
>
> This is a patch which enables incremental Harmony build via conventional federated build option "build". Testing changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5521) [build] fix incremental federated build

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569689#action_12569689 ] 

Alexei Fedotov commented on HARMONY-5521:
-----------------------------------------

The incremental build on workspace without any changes reports on my notebook:
real    3m25.580s
user    0m0.563s
sys     0m0.491s


> [build] fix incremental federated build
> ---------------------------------------
>
>                 Key: HARMONY-5521
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5521
>             Project: Harmony
>          Issue Type: Improvement
>          Components: build - test - ci
>            Reporter: Alexei Fedotov
>         Attachments: incremental_build.patch
>
>
> This is a patch which enables incremental Harmony build via conventional federated build option "build". Testing changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-5521) [build] fix incremental federated build

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov closed HARMONY-5521.
-----------------------------------

    Resolution: Fixed

Thanks Pavel! It works. I will file a separate JIRA to update our contributor guide.

> [build] fix incremental federated build
> ---------------------------------------
>
>                 Key: HARMONY-5521
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5521
>             Project: Harmony
>          Issue Type: Improvement
>          Components: build - test - ci
>            Reporter: Alexei Fedotov
>            Assignee: Pavel Pervov
>         Attachments: incremental_build.patch, incremental_build_1.patch, incremental_build_2.patch
>
>
> This is a patch which enables incremental Harmony build via conventional federated build option "build". Testing changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5521) [build] fix incremental federated build

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov updated HARMONY-5521:
------------------------------------

    Attachment: incremental_build.patch

BTW, ASF license note is shown in a following way: 
 attach.notlicensed.description
 attach.licensed.description 

> [build] fix incremental federated build
> ---------------------------------------
>
>                 Key: HARMONY-5521
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5521
>             Project: Harmony
>          Issue Type: Improvement
>          Components: build - test - ci
>            Reporter: Alexei Fedotov
>         Attachments: incremental_build.patch
>
>
> This is a patch which enables incremental Harmony build via conventional federated build option "build". Testing changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5521) [build] fix incremental federated build

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov updated HARMONY-5521:
------------------------------------

    Attachment: incremental_build_2.patch

> [build] fix incremental federated build
> ---------------------------------------
>
>                 Key: HARMONY-5521
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5521
>             Project: Harmony
>          Issue Type: Improvement
>          Components: build - test - ci
>            Reporter: Alexei Fedotov
>            Assignee: Pavel Pervov
>         Attachments: incremental_build.patch, incremental_build_1.patch, incremental_build_2.patch
>
>
> This is a patch which enables incremental Harmony build via conventional federated build option "build". Testing changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5521) [build] fix incremental federated build

Posted by "Pavel Pervov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583061#action_12583061 ] 

Pavel Pervov commented on HARMONY-5521:
---------------------------------------

Committed revision 642255. Please, check that the patch is applied correctly.

> [build] fix incremental federated build
> ---------------------------------------
>
>                 Key: HARMONY-5521
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5521
>             Project: Harmony
>          Issue Type: Improvement
>          Components: build - test - ci
>            Reporter: Alexei Fedotov
>            Assignee: Pavel Pervov
>         Attachments: incremental_build.patch, incremental_build_1.patch, incremental_build_2.patch
>
>
> This is a patch which enables incremental Harmony build via conventional federated build option "build". Testing changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5521) [build] fix incremental federated build

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov updated HARMONY-5521:
------------------------------------

    Attachment:     (was: incremental_build_2.patch)

> [build] fix incremental federated build
> ---------------------------------------
>
>                 Key: HARMONY-5521
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5521
>             Project: Harmony
>          Issue Type: Improvement
>          Components: build - test - ci
>            Reporter: Alexei Fedotov
>            Assignee: Pavel Pervov
>         Attachments: incremental_build.patch, incremental_build_1.patch
>
>
> This is a patch which enables incremental Harmony build via conventional federated build option "build". Testing changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5521) [build] fix incremental federated build

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582662#action_12582662 ] 

Tim Ellison commented on HARMONY-5521:
--------------------------------------

Why not make the incremental build the default?  This is more likely the one people will be using daily.


> [build] fix incremental federated build
> ---------------------------------------
>
>                 Key: HARMONY-5521
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5521
>             Project: Harmony
>          Issue Type: Improvement
>          Components: build - test - ci
>            Reporter: Alexei Fedotov
>            Assignee: Pavel Pervov
>         Attachments: incremental_build.patch
>
>
> This is a patch which enables incremental Harmony build via conventional federated build option "build". Testing changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5521) [build] fix incremental federated build

Posted by "Pavel Pervov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582141#action_12582141 ] 

Pavel Pervov commented on HARMONY-5521:
---------------------------------------

Finally, the patch. I ususally do it by hand.

Small comment: as I understand the patch now user can specify 'build' target to federated build and this will mean "incremental" while 'default' and 'make-snapshot' targets are kept as they were operating originally.

> [build] fix incremental federated build
> ---------------------------------------
>
>                 Key: HARMONY-5521
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5521
>             Project: Harmony
>          Issue Type: Improvement
>          Components: build - test - ci
>            Reporter: Alexei Fedotov
>            Assignee: Pavel Pervov
>         Attachments: incremental_build.patch
>
>
> This is a patch which enables incremental Harmony build via conventional federated build option "build". Testing changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5521) [build] fix incremental federated build

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582145#action_12582145 ] 

Alexei Fedotov commented on HARMONY-5521:
-----------------------------------------

Exactly. More exactly, the build target existed earlier and was named build-all. I've just rewritten the misleading contract for this target to re-build harmony, eg clean, then build.

> [build] fix incremental federated build
> ---------------------------------------
>
>                 Key: HARMONY-5521
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5521
>             Project: Harmony
>          Issue Type: Improvement
>          Components: build - test - ci
>            Reporter: Alexei Fedotov
>            Assignee: Pavel Pervov
>         Attachments: incremental_build.patch
>
>
> This is a patch which enables incremental Harmony build via conventional federated build option "build". Testing changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5521) [build] fix incremental federated build

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov updated HARMONY-5521:
------------------------------------

    Attachment: incremental_build_2.patch

The patch adds classlib-like targets, a help for this targets, reformats comments to fit my screen and fixes unconditional fetch of the common_resources module. The module was always fetched regardless of auto.fetch setting.


> [build] fix incremental federated build
> ---------------------------------------
>
>                 Key: HARMONY-5521
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5521
>             Project: Harmony
>          Issue Type: Improvement
>          Components: build - test - ci
>            Reporter: Alexei Fedotov
>            Assignee: Pavel Pervov
>         Attachments: incremental_build.patch, incremental_build_1.patch, incremental_build_2.patch
>
>
> This is a patch which enables incremental Harmony build via conventional federated build option "build". Testing changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.