You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/02/09 19:22:24 UTC
[GitHub] [accumulo] jmark99 opened a new pull request #2476: Utilize Uninterruptibles.joinUninterruptibly in ServiceLockIT
jmark99 opened a new pull request #2476:
URL: https://github.com/apache/accumulo/pull/2476
Replace t.join within the try/catch of ServiceLockIT with the use of Uninterruptibles.joinUninterruptibly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] jmark99 merged pull request #2476: Utilize Uninterruptibles.joinUninterruptibly in ServiceLockIT
Posted by GitBox <gi...@apache.org>.
jmark99 merged pull request #2476:
URL: https://github.com/apache/accumulo/pull/2476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #2476: Utilize Uninterruptibles.joinUninterruptibly in ServiceLockIT
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #2476:
URL: https://github.com/apache/accumulo/pull/2476#discussion_r803094824
##########
File path: test/src/main/java/org/apache/accumulo/test/fate/zookeeper/ServiceLockIT.java
##########
@@ -623,11 +625,7 @@ public void testLockParallel() throws Exception {
assertEquals(0, zk.getChildren(parent.toString(), false).size());
threads.forEach(t -> {
- try {
- t.join();
- } catch (InterruptedException e) {
- // ignore
- }
+ Uninterruptibles.joinUninterruptibly(t);
Review comment:
This could be:
```java
threads.forEach(Uninterruptibles::joinUninterruptibly);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org