You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vishal Suvagia <vi...@yahoo.com> on 2017/02/03 14:18:48 UTC

Review Request 56278: AMBARI-19864 : Zookeeper namespace for Hive service should be taken from hive-interactive-site, when only Hive-server Interactive is installed.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56278/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar, Oliver Szabo, and Velmurugan Periasamy.


Bugs: AMBARI-19864
    https://issues.apache.org/jira/browse/AMBARI-19864


Repository: ambari


Description
-------

If only Hive-Server Interactive is installed, then zoo-keeper name space for hive service configured for Ranger should be taken from hive-interactive-site and not from hive-site.


Diffs
-----

  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bee263a 

Diff: https://reviews.apache.org/r/56278/diff/


Testing
-------

Verified installation on CentOS-6.


Thanks,

Vishal Suvagia


Re: Review Request 56278: AMBARI-19864 : Zookeeper namespace for Hive service should be taken from hive-interactive-site, when only Hive-server Interactive is installed.

Posted by Mugdha Varadkar <mu...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56278/#review164339
-----------------------------------------------------------


Ship it!




Ship It!

- Mugdha Varadkar


On Feb. 6, 2017, 6:31 a.m., Vishal Suvagia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56278/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2017, 6:31 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar, Oliver Szabo, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-19864
>     https://issues.apache.org/jira/browse/AMBARI-19864
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If only Hive-Server Interactive is installed, then zoo-keeper name space for hive service configured for Ranger should be taken from hive-interactive-site and not from hive-site.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 211fe0a 
> 
> Diff: https://reviews.apache.org/r/56278/diff/
> 
> 
> Testing
> -------
> 
> Verified installation on CentOS-6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>


Re: Review Request 56278: AMBARI-19864 : Zookeeper namespace for Hive service should be taken from hive-interactive-site, when only Hive-server Interactive is installed.

Posted by Vishal Suvagia <vi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56278/
-----------------------------------------------------------

(Updated Feb. 6, 2017, 6:31 a.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar, Oliver Szabo, Sumit Mohanty, and Velmurugan Periasamy.


Changes
-------

Adding condition to read hive.server2.zookeeper.namespace value, instead of always reading from hive-site.


Bugs: AMBARI-19864
    https://issues.apache.org/jira/browse/AMBARI-19864


Repository: ambari


Description
-------

If only Hive-Server Interactive is installed, then zoo-keeper name space for hive service configured for Ranger should be taken from hive-interactive-site and not from hive-site.


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 211fe0a 

Diff: https://reviews.apache.org/r/56278/diff/


Testing
-------

Verified installation on CentOS-6.


Thanks,

Vishal Suvagia


Re: Review Request 56278: AMBARI-19864 : Zookeeper namespace for Hive service should be taken from hive-interactive-site, when only Hive-server Interactive is installed.

Posted by Vishal Suvagia <vi...@yahoo.com>.

> On Feb. 4, 2017, 2:45 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py, line 708
> > <https://reviews.apache.org/r/56278/diff/1/?file=1623345#file1623345line708>
> >
> >     Would suggest a slightly safer approach of reading it in the else from hive-site instead of always reading from hive-site. Some one at some point will think that that property is not used and delete it from hive-site so that their users do not see it twice on the dashboard when they only have HSI

Fixed


- Vishal


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56278/#review164233
-----------------------------------------------------------


On Feb. 3, 2017, 2:18 p.m., Vishal Suvagia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56278/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2017, 2:18 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar, Oliver Szabo, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-19864
>     https://issues.apache.org/jira/browse/AMBARI-19864
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If only Hive-Server Interactive is installed, then zoo-keeper name space for hive service configured for Ranger should be taken from hive-interactive-site and not from hive-site.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bee263a 
> 
> Diff: https://reviews.apache.org/r/56278/diff/
> 
> 
> Testing
> -------
> 
> Verified installation on CentOS-6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>


Re: Review Request 56278: AMBARI-19864 : Zookeeper namespace for Hive service should be taken from hive-interactive-site, when only Hive-server Interactive is installed.

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56278/#review164233
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py (line 708)
<https://reviews.apache.org/r/56278/#comment235892>

    Would suggest a slightly safer approach of reading it in the else from hive-site instead of always reading from hive-site. Some one at some point will think that that property is not used and delete it from hive-site so that their users do not see it twice on the dashboard when they only have HSI


- Sumit Mohanty


On Feb. 3, 2017, 2:18 p.m., Vishal Suvagia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56278/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2017, 2:18 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar, Oliver Szabo, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-19864
>     https://issues.apache.org/jira/browse/AMBARI-19864
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If only Hive-Server Interactive is installed, then zoo-keeper name space for hive service configured for Ranger should be taken from hive-interactive-site and not from hive-site.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bee263a 
> 
> Diff: https://reviews.apache.org/r/56278/diff/
> 
> 
> Testing
> -------
> 
> Verified installation on CentOS-6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>


Re: Review Request 56278: AMBARI-19864 : Zookeeper namespace for Hive service should be taken from hive-interactive-site, when only Hive-server Interactive is installed.

Posted by Vishal Suvagia <vi...@yahoo.com>.

> On Feb. 4, 2017, 2:45 a.m., Sumit Mohanty wrote:
> > Fix it and ship it.

Fixed


- Vishal


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56278/#review164234
-----------------------------------------------------------


On Feb. 3, 2017, 2:18 p.m., Vishal Suvagia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56278/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2017, 2:18 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar, Oliver Szabo, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-19864
>     https://issues.apache.org/jira/browse/AMBARI-19864
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If only Hive-Server Interactive is installed, then zoo-keeper name space for hive service configured for Ranger should be taken from hive-interactive-site and not from hive-site.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bee263a 
> 
> Diff: https://reviews.apache.org/r/56278/diff/
> 
> 
> Testing
> -------
> 
> Verified installation on CentOS-6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>


Re: Review Request 56278: AMBARI-19864 : Zookeeper namespace for Hive service should be taken from hive-interactive-site, when only Hive-server Interactive is installed.

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56278/#review164234
-----------------------------------------------------------


Ship it!




Fix it and ship it.

- Sumit Mohanty


On Feb. 3, 2017, 2:18 p.m., Vishal Suvagia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56278/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2017, 2:18 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar, Oliver Szabo, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-19864
>     https://issues.apache.org/jira/browse/AMBARI-19864
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If only Hive-Server Interactive is installed, then zoo-keeper name space for hive service configured for Ranger should be taken from hive-interactive-site and not from hive-site.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bee263a 
> 
> Diff: https://reviews.apache.org/r/56278/diff/
> 
> 
> Testing
> -------
> 
> Verified installation on CentOS-6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>