You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/03/13 09:33:49 UTC
[GitHub] [fineract-cn-mobile] PatelVatsalB21 opened a new pull request #123: Fix-253: FAB behaviour rectified in LoanAccountsFragment
PatelVatsalB21 opened a new pull request #123:
URL: https://github.com/apache/fineract-cn-mobile/pull/123
Fixes FINCN-253
Fab is now visible as soon as list gets idle from scrolling.
**Error**
https://user-images.githubusercontent.com/70195106/111025808-b79e2200-840c-11eb-936b-0ae14258e967.mp4
**Solution**
https://user-images.githubusercontent.com/70195106/111025890-267b7b00-840d-11eb-8cf4-fb39ab238d7f.mp4
- [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio.
- [x] Run the unit tests with `./gradlew check` to make sure you didn't break anything.
- [x] If you have multiple commits please combine them into one commit by squashing them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] PatelVatsalB21 commented on pull request #123: Fix-253: FAB behaviour rectified in LoanAccountsFragment
Posted by GitBox <gi...@apache.org>.
PatelVatsalB21 commented on pull request #123:
URL: https://github.com/apache/fineract-cn-mobile/pull/123#issuecomment-800114555
@jawidMuhammadi please review it, i have changed fab name as per your instructions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] jawidMuhammadi commented on a change in pull request #123: Fix-253: FAB behaviour rectified in LoanAccountsFragment
Posted by GitBox <gi...@apache.org>.
jawidMuhammadi commented on a change in pull request #123:
URL: https://github.com/apache/fineract-cn-mobile/pull/123#discussion_r594563917
##########
File path: app/src/main/java/org/apache/fineract/ui/online/loanaccounts/loanaccountlist/LoanAccountsFragment.java
##########
@@ -53,6 +57,9 @@
@BindView(R.id.layout_error)
View layoutError;
+ @BindView(R.id.fab_add_customer_loan)
+ FloatingActionButton fabLoan;
Review comment:
Please rename the view from `fabLoan` to `fabAddCustomerLoan`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] PatelVatsalB21 commented on a change in pull request #123: Fix-253: FAB behaviour rectified in LoanAccountsFragment
Posted by GitBox <gi...@apache.org>.
PatelVatsalB21 commented on a change in pull request #123:
URL: https://github.com/apache/fineract-cn-mobile/pull/123#discussion_r594591628
##########
File path: app/src/main/java/org/apache/fineract/ui/online/loanaccounts/loanaccountlist/LoanAccountsFragment.java
##########
@@ -53,6 +57,9 @@
@BindView(R.id.layout_error)
View layoutError;
+ @BindView(R.id.fab_add_customer_loan)
+ FloatingActionButton fabLoan;
Review comment:
I will change it ASAP
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org