[GitHub] [spark] xinrong-databricks commented on a diff in pull request #36028: [SPARK-38726][PYTHON] Support `how` parameter of `MultiIndex.dropna`

[GitBox <gi...@apache.org>]

xinrong-databricks commented on code in PR #36028:
URL: https://github.com/apache/spark/pull/36028#discussion_r843075944


##########
python/pyspark/pandas/indexes/base.py:
##########
@@ -1141,10 +1141,21 @@ def is_type_compatible(self, kind: str) -> bool:
         """
         return kind == self.inferred_type
 
-    def dropna(self) -> "Index":
+    def dropna(self, how: str = "any") -> "Index":
         """
         Return Index or MultiIndex without NA/NaN values
 
+        Parameters
+        ----------
+        how : {'any', 'all'}, default 'any'
+            If the Index is a MultiIndex, drop the value when any or all levels
+            are NaN.
+
+

Review Comment:
   Good catch!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org