You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Michael Park <mc...@gmail.com> on 2016/01/21 00:40:26 UTC

Re: `F()` vs `F(void)`

`void` parameters are no longer with us.

https://github.com/apache/mesos/commit/93a5708294d6d66a5e1350a0bb1c8fe87605ee1d
https://github.com/apache/mesos/commit/05f9fb2fa66968f37418d28fc8cebd0770a54dca
https://github.com/apache/mesos/commit/4d4d7166414f0ebd8d5e40df34070446098a3c91

On Mon, Dec 14, 2015 at 5:36 AM Alexander Rojas <al...@mesosphere.io>
wrote:

> +1
>
> > On 13 Dec 2015, at 19:46, Michael Park <mp...@apache.org> wrote:
> >
> > Hello,
> >
> > In the C++ world, the *void* parameter is considered to be only there
> for C
> > compatibility reasons.
> >
> > We do a good job of not using *void *parameters in function declarations,
> > e.g., *void F();*. On the other hand, we're *not* so good doing so for
> > function types, e.g., *std::function<void(void)>*.
> >
> > I would like to see the codebase converge to *not* use *void* as a
> > parameter type, and would like feedback if anyone holds strong opposing
> > opinions.
> >
> > Thanks,
> >
> > MPark.
>
>

Re: `F()` vs `F(void)`

Posted by Bernd Mathiske <be...@mesosphere.io>.
High five!

> On Jan 21, 2016, at 12:40 AM, Michael Park <mc...@gmail.com> wrote:
> 
> `void` parameters are no longer with us.
> 
> https://github.com/apache/mesos/commit/93a5708294d6d66a5e1350a0bb1c8fe87605ee1d
> https://github.com/apache/mesos/commit/05f9fb2fa66968f37418d28fc8cebd0770a54dca
> https://github.com/apache/mesos/commit/4d4d7166414f0ebd8d5e40df34070446098a3c91
> 
> On Mon, Dec 14, 2015 at 5:36 AM Alexander Rojas <al...@mesosphere.io>
> wrote:
> 
>> +1
>> 
>>> On 13 Dec 2015, at 19:46, Michael Park <mp...@apache.org> wrote:
>>> 
>>> Hello,
>>> 
>>> In the C++ world, the *void* parameter is considered to be only there
>> for C
>>> compatibility reasons.
>>> 
>>> We do a good job of not using *void *parameters in function declarations,
>>> e.g., *void F();*. On the other hand, we're *not* so good doing so for
>>> function types, e.g., *std::function<void(void)>*.
>>> 
>>> I would like to see the codebase converge to *not* use *void* as a
>>> parameter type, and would like feedback if anyone holds strong opposing
>>> opinions.
>>> 
>>> Thanks,
>>> 
>>> MPark.
>> 
>>