You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/28 08:52:00 UTC
[GitHub] [superset] iercan opened a new issue #16866: DASHBOARD_CROSS_FILTER causes some bugs and performance issues
iercan opened a new issue #16866:
URL: https://github.com/apache/superset/issues/16866
Hi.
I was unable to edit filter scopes on dashboards and also when I changed time range and save as dashboard they weren't persistent. We were also experiencing very slow load when dashboard size gets bigger.
After some test I realized this is because DASHBOARD_CROSS_FILTER flag enabled. After disabled it, dashboard get much faster and I can save scopes and times of filter.
Although this flag listed as stable looks like it has serious bug and performance issue.
#### How to reproduce the bug
1. Enable DASHBOARD_CROSS_FILTER in feature flag.
2. Add some filter box and chart to dashboard
2. Try to change filter scopes and default time range
3. Refresh dashboard
### Expected results
Scopes should be persistent
Time settings should be saved
Dashboard should load faster
### Actual results
Scopes are not saved
Time settings are not saved
Dashboard loads slow
### Environment
- browser type and version: Chrome 94
- superset version: using apache/superset:1.3 docker image
```
"SQLLAB_BACKEND_PERSISTENCE": True,
"THUMBNAILS": True,
"THUMBNAILS_SQLA_LISTENERS": True,
"ALERT_REPORTS": True,
"DASHBOARD_NATIVE_FILTERS": True,
"DASHBOARD_CROSS_FILTERS": True,
"DASHBOARD_RBAC": True,
"ENABLE_EXPLORE_DRAG_AND_DROP": True,
```
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [X] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [X] I have reproduced the issue with at least the latest released version of superset.
- [X] I have checked the issue tracker for the same issue and I haven't found one similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #16866: DASHBOARD_CROSS_FILTER causes some bugs and performance issues
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16866:
URL: https://github.com/apache/superset/issues/16866#issuecomment-929402098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on issue #16866: DASHBOARD_CROSS_FILTER causes some bugs and performance issues
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #16866:
URL: https://github.com/apache/superset/issues/16866#issuecomment-943393084
@iercan Current master contains changes that improve dashboard performance significantly (see PRs #16421, #16444, #16525, #16545). They are not included in the latest released version (1.3), but should be in the upcoming 1.4. I hope you'll give native filters another shot then 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #16866: DASHBOARD_CROSS_FILTER causes some bugs and performance issues
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16866:
URL: https://github.com/apache/superset/issues/16866#issuecomment-941610523
@kgabryje 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #16866: DASHBOARD_CROSS_FILTER causes some bugs and performance issues
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16866:
URL: https://github.com/apache/superset/issues/16866#issuecomment-929402098
Hi @iercan thanks for reporting this issue!
So there are _ issues here.
- When Cross-filtering is enabled, dashboard perf is being affected
Question: 1. how large is your dashboard? number of charts, types of charts etc.
2. is it happening when you try to emit filters? or while you perform other tasks in dashboard, or just slow in
general?
- Unable to edit filter scope of NATIVE FILTER when Cross-filtering is enabled (?) or Cross-filter scope
- Time range issue also happen only when Cross-filtering is enabled? or without it as well?
@villebro let's wait for more information before jumping in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #16866: DASHBOARD_CROSS_FILTER causes some bugs and performance issues
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16866:
URL: https://github.com/apache/superset/issues/16866#issuecomment-929405084
Also, is there a specific reason you are still adding filterbox to the dashboard while native filter is available? these two are not compatible, especially on time filter. and we dont have plan to maintain the combination. can you try remove filter box to see if the time range issue still persist?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] iercan commented on issue #16866: DASHBOARD_CROSS_FILTER causes some bugs and performance issues
Posted by GitBox <gi...@apache.org>.
iercan commented on issue #16866:
URL: https://github.com/apache/superset/issues/16866#issuecomment-929407659
> Hi @iercan thanks for reporting this issue!
>
> So there are _ issues here.
>
> * When Cross-filtering is enabled, dashboard perf is being affected
> Question: 1. how large is your dashboard? number of charts, types of charts etc.
> 2. is it happening when you try to emit filters? or while you perform other tasks in dashboard, or just slow in
> general?
Dashboard has about 80 chart and 3 different filter box. It slows on loads and also navigating through tabs in the dashboard. and also while selecting filters
> * Unable to edit filter scope of NATIVE FILTER when Cross-filtering is enabled (?) or Cross-filter scope
Problem is not about native filter, we added filter boxes.
> * Time range issue also happen only when Cross-filtering is enabled? or without it as well?
It happens when option is enabled. Again this is also for filter boxes, not native filter.
> Also, is there a specific reason you are still adding filterbox to the dashboard while native filter is available? these two are not compatible, especially on time filter. and we dont have plan to maintain the combination. can you try remove filter box to see if the time range issue still persist?
We experienced very slow load and navigate with native filter when dahsboard gets too big. Thats why we decided to use filter boxes for big dashboards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] iercan commented on issue #16866: DASHBOARD_CROSS_FILTER causes some bugs and performance issues
Posted by GitBox <gi...@apache.org>.
iercan commented on issue #16866:
URL: https://github.com/apache/superset/issues/16866#issuecomment-1022236565
I've tested 1.4.0 and problem still exist. We are still not able to use native filters for big dashboards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] iercan commented on issue #16866: DASHBOARD_CROSS_FILTER causes some bugs and performance issues
Posted by GitBox <gi...@apache.org>.
iercan commented on issue #16866:
URL: https://github.com/apache/superset/issues/16866#issuecomment-943440691
I just also tried master branch again. Result looks same. Also let me remind you that point of this issue is not just native filter. I wanted to point issues about cross filter too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] iercan commented on issue #16866: DASHBOARD_CROSS_FILTER causes some bugs and performance issues
Posted by GitBox <gi...@apache.org>.
iercan commented on issue #16866:
URL: https://github.com/apache/superset/issues/16866#issuecomment-944284941
I can not share video since they contain sensitive informations. We have about 20+ native filters, 120+ charts, and many nested tabs with depths vary from 1 to 4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] iercan commented on issue #16866: DASHBOARD_CROSS_FILTER causes some bugs and performance issues
Posted by GitBox <gi...@apache.org>.
iercan commented on issue #16866:
URL: https://github.com/apache/superset/issues/16866#issuecomment-929563642
Yeah performance issue still exist. As I mention on previous answer we tried native filter first but it was very slow that's why we decided to try filter boxes. At last we resolved issue by disabling cross filters and using filter box. I also tried native filters with cross filter disabled but still it is very slow compared to filter boxes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] iercan edited a comment on issue #16866: DASHBOARD_CROSS_FILTER causes some bugs and performance issues
Posted by GitBox <gi...@apache.org>.
iercan edited a comment on issue #16866:
URL: https://github.com/apache/superset/issues/16866#issuecomment-944284941
I can not share video since they contain sensitive informations. We have about 20+ native filters, 120+ charts, and many nested tabs with depths vary from 1 to 4. Problem is not just loading time here. When we try to navigate through tabs, page response 2-5 seconds after click and it is frustrating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #16866: DASHBOARD_CROSS_FILTER causes some bugs and performance issues
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16866:
URL: https://github.com/apache/superset/issues/16866#issuecomment-941610523
@kgabryje 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] iercan edited a comment on issue #16866: DASHBOARD_CROSS_FILTER causes some bugs and performance issues
Posted by GitBox <gi...@apache.org>.
iercan edited a comment on issue #16866:
URL: https://github.com/apache/superset/issues/16866#issuecomment-929407659
> Hi @iercan thanks for reporting this issue!
>
> So there are _ issues here.
>
> * When Cross-filtering is enabled, dashboard perf is being affected
> Question: 1. how large is your dashboard? number of charts, types of charts etc.
> 2. is it happening when you try to emit filters? or while you perform other tasks in dashboard, or just slow in
> general?
Dashboard has about 80 chart and 3 different filter box. It slows on loads and also navigating through tabs in the dashboard. and also while selecting filters
> * Unable to edit filter scope of NATIVE FILTER when Cross-filtering is enabled (?) or Cross-filter scope
Problem is not about native filter, we added filter boxes.
> * Time range issue also happen only when Cross-filtering is enabled? or without it as well?
It happens when option is enabled. Again this is also for filter boxes, not native filter.
> Also, is there a specific reason you are still adding filterbox to the dashboard while native filter is available? these two are not compatible, especially on time filter. and we dont have plan to maintain the combination. can you try remove filter box to see if the time range issue still persist?
We experienced very slow load and navigate with native filter when dahsboard gets too big. Thats why we decided to use filter boxes for big dashboards. We are not using hybrid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #16866: DASHBOARD_CROSS_FILTER causes some bugs and performance issues
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16866:
URL: https://github.com/apache/superset/issues/16866#issuecomment-929512351
@iercan thanks for the details! We suspect that having FilterBox coexist in Native filter enabled dashboard caused some of the issues your mention. Can you please remove your filterbox and create the same filters using native filters? and let us know if perf is still an issue. If so, we are happy to address.
I'm pretty sure time range and scoping works as expected in that case.
We are in the process of deprecating filterbox, im afraid that we can not help you troubleshoot Filterboxes are on your dashboard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on issue #16866: DASHBOARD_CROSS_FILTER causes some bugs and performance issues
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #16866:
URL: https://github.com/apache/superset/issues/16866#issuecomment-943479240
Thanks for clarifying! I've created a test dashboard with ~80 charts and ~15 native filters and the performance after load is pretty similar with and without cross filtering and native filters feature flags. Would you be able to share a recording of your dashboard so that I can reproduce it as closely as possible? If you can't, can you share some details like the layout of your dashboard (like the number of tabs, nested tabs, number of charts under each tab)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] iercan edited a comment on issue #16866: DASHBOARD_CROSS_FILTER causes some bugs and performance issues
Posted by GitBox <gi...@apache.org>.
iercan edited a comment on issue #16866:
URL: https://github.com/apache/superset/issues/16866#issuecomment-929407659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] iercan edited a comment on issue #16866: DASHBOARD_CROSS_FILTER causes some bugs and performance issues
Posted by GitBox <gi...@apache.org>.
iercan edited a comment on issue #16866:
URL: https://github.com/apache/superset/issues/16866#issuecomment-929563642
Yeah performance issue still exist. As I mention on previous answer we tried native filter first but it was very slow that's why we decided to try filter boxes. At last we resolved issue by disabling cross filters and using filter box. I also tried native filters with cross filter disabled but still it is very slow compared to filter boxes.
Native filter don't have other bugs but it is so slow to use in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] iercan commented on issue #16866: DASHBOARD_CROSS_FILTER causes some bugs and performance issues
Posted by GitBox <gi...@apache.org>.
iercan commented on issue #16866:
URL: https://github.com/apache/superset/issues/16866#issuecomment-929407659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] iercan commented on issue #16866: DASHBOARD_CROSS_FILTER causes some bugs and performance issues
Posted by GitBox <gi...@apache.org>.
iercan commented on issue #16866:
URL: https://github.com/apache/superset/issues/16866#issuecomment-943404975
On the date I open this issue I also tried master branch and result was same in terms of performance. I checked the dates of PR links you send. Looks like I already tried them. But sure I will check new releases...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cyanoboy commented on issue #16866: DASHBOARD_CROSS_FILTER causes some bugs and performance issues
Posted by GitBox <gi...@apache.org>.
cyanoboy commented on issue #16866:
URL: https://github.com/apache/superset/issues/16866#issuecomment-1029831428
The same happens to me.
Superset v1.3.2 with DASHBOARD_CROSS_FILTER enabled, big dashboards take a few seconds to switch from one tab to the other. By disabling DASHBOARD_CROSS_FILTER it works flawlessly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org