You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/11/17 14:37:52 UTC
[GitHub] [commons-text] pbelousov opened a new pull request, #387: Rollback TextStringBuidler#hashCode implementation to 1.8 release
pbelousov opened a new pull request, #387:
URL: https://github.com/apache/commons-text/pull/387
The implementation that was done in the scope of the PR !281 introduced higher rate of garbage collections because of additional allocations of String object. So I returned the code to the logic it had in the 1.8 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-text] pbelousov commented on pull request #387: Rollback TextStringBuidler#hashCode implementation to 1.8 release
Posted by GitBox <gi...@apache.org>.
pbelousov commented on PR #387:
URL: https://github.com/apache/commons-text/pull/387#issuecomment-1318736601
@garydgregory Sorry, I cannot answer you on the mailing list as I haven't gotten your email (it seems due to some firewall settings). So I've created PR as you suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-text] garydgregory commented on pull request #387: Rollback TextStringBuidler#hashCode implementation to 1.8 release
Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #387:
URL: https://github.com/apache/commons-text/pull/387#issuecomment-1319132366
Hi @pbelousov
Thank you for the PR.
Ah, I see...
After looking at OpenJDK's `Arrays.hashCode(char[])` I flipped the loop traversal to start at 0.
Please review git master and close.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-text] pbelousov closed pull request #387: Rollback TextStringBuidler#hashCode implementation to 1.8 release
Posted by GitBox <gi...@apache.org>.
pbelousov closed pull request #387: Rollback TextStringBuidler#hashCode implementation to 1.8 release
URL: https://github.com/apache/commons-text/pull/387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-text] pbelousov commented on pull request #387: Rollback TextStringBuidler#hashCode implementation to 1.8 release
Posted by GitBox <gi...@apache.org>.
pbelousov commented on PR #387:
URL: https://github.com/apache/commons-text/pull/387#issuecomment-1319205471
Thank you @garydgregory! That's perfectly fine for my use case!
Just one question - when could it be released in order for we could get it from Maven central repo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-text] garydgregory commented on pull request #387: Rollback TextStringBuidler#hashCode implementation to 1.8 release
Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #387:
URL: https://github.com/apache/commons-text/pull/387#issuecomment-1319223957
You can get it from the Apache snapshot Maven repository, no release date planned yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-text] pbelousov commented on pull request #387: Rollback TextStringBuidler#hashCode implementation to 1.8 release
Posted by GitBox <gi...@apache.org>.
pbelousov commented on PR #387:
URL: https://github.com/apache/commons-text/pull/387#issuecomment-1319225386
Got it! Thank you again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org