[GitHub] [apisix] poidl commented on issue #2362: prometheus plugin publicly exposes metrics, even if not enabled

[GitBox <gi...@apache.org>]

poidl commented on issue #2362:
URL: https://github.com/apache/apisix/issues/2362#issuecomment-717157968


   I see, thanks! 
   
   I lack the technical background to participate in a full discussion. The important thing for me is that APISIX exposes a route only if I explicitly tell it to do so.
   
   What about serving the metrics at 9101 (or some other port), and if you want to expose it on 80/443, just define the 9101 as upstream and define a route `/apisix/prometheus/metrics` as usual? Would this defeat the purpose of a metrics tool, in the sense  that it should even be accessible if apisix is cannot or does not serve routes as usual for some reason. For example, would there be a requirement for metrics logging *before* any route has been defined?
   
   In that case the only solution I could think of is deploying a separate reverse proxy that exposes 9101 on 80/443, independent of apisix. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org