You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "snuyanzin (via GitHub)" <gi...@apache.org> on 2026/01/25 21:15:22 UTC
[PR] [hotfix][tests] Catch `AssertionError` in `DiffRepository` instead of `AssertionFailedError` [flink]
snuyanzin opened a new pull request, #27471:
URL: https://github.com/apache/flink/pull/27471
## What is the purpose of the change
There `DiffRepository` is a core functionality for tests to verify plans in xml.
One of the feature it also suggests is generation of xml.
In order to do this just drop the xml for the test class and run this test, it will regenerate the whole xml.
It seems this regeneration was broken
This commit is going to fix it
## Brief change log
DiffRepository
## Verifying this change
1. Pick any class verifying xml plans
2. drop corresponding xml
3. rerun test (first time it detects that xml is absent and regenerate it, however will fail)
4. rerun it once more, now it should be green
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): ( no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
- The serializers: ( no)
- The runtime per-record code paths (performance sensitive): ( no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][tests] Catch `AssertionError` in `DiffRepository` instead of `AssertionFailedError` [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #27471:
URL: https://github.com/apache/flink/pull/27471#issuecomment-3798627307
thank you for taking a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][tests] Catch `AssertionError` in `DiffRepository` instead of `AssertionFailedError` [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #27471:
URL: https://github.com/apache/flink/pull/27471#discussion_r2725929914
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/utils/DiffRepository.java:
##########
@@ -479,7 +478,7 @@ public void assertEquals(String testCaseName, String tag, String expected, Strin
+ " but was: "
+ actualCanonical)
.isEqualTo(expected2Canonical);
- } catch (AssertionFailedError e) {
+ } catch (AssertionError e) {
Review Comment:
it was broken here
https://github.com/apache/flink/commit/3c5c15183abd9e494cd9679ab93f4f30c2b633c6
while switching to assertj
however `AssertionFailedError` was not switched
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][tests] Catch `AssertionError` in `DiffRepository` instead of `AssertionFailedError` [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #27471:
URL: https://github.com/apache/flink/pull/27471#issuecomment-3797258889
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0dbfed12d51f467b67845afd1344ea2326bf2417",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0dbfed12d51f467b67845afd1344ea2326bf2417",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0dbfed12d51f467b67845afd1344ea2326bf2417 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][tests] Catch `AssertionError` in `DiffRepository` instead of `AssertionFailedError` [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin merged PR #27471:
URL: https://github.com/apache/flink/pull/27471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org