You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/09 15:10:31 UTC
[GitHub] [airflow] gbonazzoli commented on pull request #26457: Add user comment to task instance and dag run
gbonazzoli commented on PR #26457:
URL: https://github.com/apache/airflow/pull/26457#issuecomment-1272562869
> Implement the support for notes inside Airflow.
>
> Quick showcase: http://www.giphy.com/gifs/RU8JL1GbYdSic9WiU2  [  ](https://camo.githubusercontent.com/43594d3c755ac35aa7d0630bec535015e50206d85fee58771d2dd338f5f4b0c3/68747470733a2f2f6d65646961332e67697068792e636f6d2f6d656469612f5255384a4c3147625964
53696339576955322f67697068792e6769663f6369643d373930623736313134386363356261623066333132663334366262396338356366656433343531356138656532313832267269643d67697068792e6769662663743d67) [ ](https://camo.githubusercontent.com/43594d3c755ac35aa7d0630bec535015e50206d85fee58771d2dd338f5f4b0c3/68747470733a2f2f6d65646961332e67697068792e636f6d2f6d656469612f5255384a4c314762596453696339576955322f67697068792e6769663f6369643d373930623736313134386363356261623066333132663334366262396338356366656433343531356138656532313832267269643d67697068792e6769662663743d67)
>
> Closes: #16790
>
> Steps:
>
> 1. [x] Add column to database schema.
> 2. [x] Add code inside DagRun & TaskInstance.
> 3. [x] Add code to DagRun and TaskInstance views so you can edit it there.
> 4. [x] Add code inside API to set Task & DagRun notes.
> 5. [x] Add react code to set the DagRun notes.
> 6. [x] Make it look & work somewhat decently in the react front-end.
> 7. [x] Add react code to set the TaskInstances notes.
> 8. [x] Add minor overlay over DagRuns to indicate there is a note or not.
> 9. [x] Add minor overlay over TaskInstance to indicate there is a note or not.
> 10. [x] Make it work with Mapped Instances as well.
> 11. [x] Implemented autofocus.
> 12. [x] Implemented accordion to be initially open when there is a note and closed otherwise.
> 13. [x] Fix all broken tests
> 14. [x] Added notes support in TriggerDAGRunOperator
> 15. [x] Add tests for setting notes on DagRun & TaskInstances.
> 16. [x] Change UserNotes to notes.
> 17. [x] Create collapsable user notes.
> 18. [x] Change TaskInstance API endpoint to Patch.
> 19. [x] Update names of variables.
> 20. [x] Change corner color to transparent over black.
Probably it needs to be modified also the cli program "airflow dags trigger" in order to pass the new "notes" field to the API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org