You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2017/01/05 23:59:53 UTC
Re: Review Request 55005: CMake: renamed `process_tests` to
`libprocess-tests` to match autotools.
> On Dec. 27, 2016, 1:14 p.m., Till Toenshoff wrote:
> > 3rdparty/libprocess/src/tests/CMakeLists.txt, line 67
> > <https://reviews.apache.org/r/55005/diff/1/?file=1591507#file1591507line67>
> >
> > s/process-tests/libprocess-tests/ ?
I would say this is not necessary. On `libx` is a POSIX convention. For example, `libprocess.a` on POSIX would usually be `process.lib` on Windows.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55005/#review160156
-----------------------------------------------------------
On Dec. 23, 2016, 2:09 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55005/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2016, 2:09 a.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See https://reviews.apache.org/r/55006/.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 9817426c3c924c7cd988d5bf4fd41b6a2fd4962a
> 3rdparty/libprocess/src/tests/CMakeLists.txt 4b80c397381ca2c869cd6eb7507bb9df94ce3623
>
> Diff: https://reviews.apache.org/r/55005/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>