[GitHub] [hbase] Apache9 commented on a change in pull request #4118: HBASE-26582 Prune use of Random and SecureRandom objects

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #4118:
URL: https://github.com/apache/hbase/pull/4118#discussion_r820034194



##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java
##########
@@ -2358,7 +2360,7 @@ public static void zero(byte[] b, int offset, int length) {
     Arrays.fill(b, offset, offset + length, (byte) 0);
   }
 
-  private static final SecureRandom RNG = new SecureRandom();
+  private static final Random RNG = new Random();

Review comment:
       Bytes is marked as IA.Public, so is it OK to change from SecureRandom to normal Random here?
   I'm not saying we can not do this, as there is no change on the method signatures, just asking.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org