You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/02/25 18:08:05 UTC
[GitHub] [hive] vineetgarg02 commented on a change in pull request #897: HIVE-22824: JoinProjectTranspose rule should skip Projects containing…
vineetgarg02 commented on a change in pull request #897: HIVE-22824: JoinProjectTranspose rule should skip Projects containing…
URL: https://github.com/apache/hive/pull/897#discussion_r384034467
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
##########
@@ -487,7 +483,7 @@ Operator genOPTree(PlannerContext plannerCtx) throws SemanticException {
ASTNode newAST = getOptimizedAST(newPlan);
// 1.1. Fix up the query for insert/ctas/materialized views
- newAST = fixUpAfterCbo(this.getAST(), newAST, cboCtx);
Review comment:
@kgyrtkirk The original issue for which HIVE-22578 was opened is being fixed by HIVE-22824 (this pull request's change). CBO path was failing because JoinProjectTranspose rule was removing project containing windowing (creating wrong AST).
Fall to non-cbo path should happen only for queries for which CBO isn't supported (and that will happed before fixUpAfterCbo). So I believe it is okay to change AST at this point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org