You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by xunzhang <gi...@git.apache.org> on 2016/05/25 02:32:01 UTC
[GitHub] incubator-hawq pull request: HAWQ-754. Open googletest build insid...
GitHub user xunzhang opened a pull request:
https://github.com/apache/incubator-hawq/pull/674
HAWQ-754. Open googletest build inside hawq for test usage.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xunzhang/incubator-hawq HAWQ-754
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/674.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #674
----
commit 4e8320ef20c788eb06ce3091b34deb0b1577c115
Author: xunzhang <xu...@gmail.com>
Date: 2016-05-25T02:30:25Z
HAWQ-754. Open googletest build inside hawq for test usage.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-754. Open googletest build insid...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the pull request:
https://github.com/apache/incubator-hawq/pull/674#issuecomment-221460235
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-754. Open googletest build insid...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/674#discussion_r64507841
--- Diff: configure ---
@@ -1556,7 +1556,7 @@ Optional Packages:
--with-bonjour build with Bonjour support
--with-openssl build with OpenSSL support
--without-readline do not use GNU Readline nor BSD Libedit for editing
- --with-thrift do not build thrift
+ --with-thrift build thrift
--- End diff --
Fixed & Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-754. Open googletest build insid...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the pull request:
https://github.com/apache/incubator-hawq/pull/674#issuecomment-221457966
In this pull request, I also fix comment bug for https://github.com/apache/incubator-hawq/pull/665.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-754. Open googletest build insid...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/674#discussion_r64507492
--- Diff: GNUmakefile.in ---
@@ -23,8 +22,7 @@ all:
install:
# $(MAKE) -C doc $@
-# waiting for higher version of gcc ready
-#$(MAKE) -C depends/thirdparty/googletest install
+ $(MAKE) -C depends/thirdparty/googletest install
--- End diff --
They are the same, I have already modified.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-754. Open googletest build insid...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/674#discussion_r64507421
--- Diff: configure ---
@@ -1556,7 +1556,7 @@ Optional Packages:
--with-bonjour build with Bonjour support
--with-openssl build with OpenSSL support
--without-readline do not use GNU Readline nor BSD Libedit for editing
- --with-thrift do not build thrift
+ --with-thrift build thrift
--- End diff --
ident issue? run "configure --h", I saw
--without-readline do not use GNU Readline nor BSD Libedit for editing
--with-thrift do not build thrift
--without-libyarn do not build libyarn
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-754. Open googletest build insid...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/674#discussion_r64507340
--- Diff: GNUmakefile.in ---
@@ -23,8 +22,7 @@ all:
install:
# $(MAKE) -C doc $@
-# waiting for higher version of gcc ready
-#$(MAKE) -C depends/thirdparty/googletest install
+ $(MAKE) -C depends/thirdparty/googletest install
--- End diff --
Why not $@?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-754. Open googletest build insid...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the pull request:
https://github.com/apache/incubator-hawq/pull/674#issuecomment-221457822
cc @yaoj2 @paul-guo-
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-754. Open googletest build insid...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hawq/pull/674
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-754. Open googletest build insid...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the pull request:
https://github.com/apache/incubator-hawq/pull/674#issuecomment-221458044
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---