You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by kh...@apache.org on 2018/03/04 19:00:37 UTC
[maven-ear-plugin] branch MEAR-209 created (now f621af6)
This is an automated email from the ASF dual-hosted git repository.
khmarbaise pushed a change to branch MEAR-209
in repository https://gitbox.apache.org/repos/asf/maven-ear-plugin.git.
at f621af6 [MEAR-209] - Change and use a internal unique id instead of artifactId only o Based on implementation of MEAR-171 this is not necessary anymore.
This branch includes the following new commits:
new f621af6 [MEAR-209] - Change and use a internal unique id instead of artifactId only o Based on implementation of MEAR-171 this is not necessary anymore.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
--
To stop receiving notification emails like this one, please contact
khmarbaise@apache.org.
[maven-ear-plugin] 01/01: [MEAR-209] - Change and use a internal
unique id instead of artifactId only o Based on implementation of MEAR-171
this is not necessary anymore.
Posted by kh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
khmarbaise pushed a commit to branch MEAR-209
in repository https://gitbox.apache.org/repos/asf/maven-ear-plugin.git
commit f621af684a02af173c0a6f385142ab8f5986c874
Author: Karl Heinz Marbaise <kh...@apache.org>
AuthorDate: Sun Mar 4 19:59:29 2018 +0100
[MEAR-209] - Change and use a internal unique id instead of artifactId only
o Based on implementation of MEAR-171 this is not necessary anymore.
---
.../java/org/apache/maven/plugins/ear/EarMojo.java | 36 ----------------------
1 file changed, 36 deletions(-)
diff --git a/src/main/java/org/apache/maven/plugins/ear/EarMojo.java b/src/main/java/org/apache/maven/plugins/ear/EarMojo.java
index 9e2f0c7..cbae2fc 100644
--- a/src/main/java/org/apache/maven/plugins/ear/EarMojo.java
+++ b/src/main/java/org/apache/maven/plugins/ear/EarMojo.java
@@ -272,35 +272,6 @@ public class EarMojo
@Parameter( defaultValue = "false", property = "maven.ear.duplicateArtifactsBreakTheBuild" )
private boolean duplicateArtifactsBreakTheBuild;
- private void checkModuleUniqueness()
- throws MojoExecutionException
- {
- ModuleIdentifierValidator miv = new ModuleIdentifierValidator( getModules() );
- miv.checkForDuplicateArtifacts();
- if ( miv.existDuplicateArtifacts() )
- {
- Map<String, List<EarModule>> duplicateArtifacts = miv.getDuplicateArtifacts();
- for ( Entry<String, List<EarModule>> entry : duplicateArtifacts.entrySet() )
- {
- getLog().warn( "The artifactId " + entry.getKey() + " exists more than once in the modules list." );
- for ( EarModule earModule : entry.getValue() )
- {
- getLog().warn( " --> " + earModule.getArtifact().getId() + " (" + earModule.getType() + ")" );
- }
- }
-
- getLog().warn( "HINT: This can be simply solved by using the <fileNameMapping>full</fileNameMapping>" );
-
- if ( duplicateArtifactsBreakTheBuild )
- {
- // CHECKSTYLE_OFF: LineLength
- throw new MojoExecutionException( "The build contains duplicate artifacts which result in unpredictable ear content." );
- // CHECKSTYLE_ON: LineLength
- }
- }
-
- }
-
/** {@inheritDoc} */
public void execute()
throws MojoExecutionException, MojoFailureException
@@ -396,13 +367,6 @@ public class EarMojo
{
try
{
- // TODO: With the next major release the modules
- // should be identified by a unique id instead of the
- // the artifactId's only which means this
- // check can be removed.
- // https://issues.apache.org/jira/browse/MEAR-209
- checkModuleUniqueness();
-
for ( EarModule module : getModules() )
{
final File sourceFile = module.getArtifact().getFile();
--
To stop receiving notification emails like this one, please contact
khmarbaise@apache.org.