You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/03 21:06:46 UTC

[GitHub] [airflow] coopergillan commented on a change in pull request #10025: Typing coverage of amazon/aws/athena

coopergillan commented on a change in pull request #10025:
URL: https://github.com/apache/airflow/pull/10025#discussion_r464662291



##########
File path: airflow/providers/amazon/aws/operators/athena.py
##########
@@ -72,19 +82,17 @@ def __init__(  # pylint: disable=too-many-arguments
         self.result_configuration = result_configuration or {}
         self.sleep_time = sleep_time
         self.max_tries = max_tries
-        self.query_execution_id = None
-        self.hook = None
+        self.query_execution_id = None  # type: Optional[str]
 
-    def get_hook(self):
+    @cached_property

Review comment:
       This is great! TIL.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org