You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Brian Moseley (JIRA)" <ji...@apache.org> on 2005/07/07 00:49:10 UTC
[jira] Created: (JCR-165) add ability to ignore specific node types when generating webdav directory listing
add ability to ignore specific node types when generating webdav directory listing
----------------------------------------------------------------------------------
Key: JCR-165
URL: http://issues.apache.org/jira/browse/JCR-165
Project: Jackrabbit
Type: Improvement
Versions: 1.0
Reporter: Brian Moseley
Priority: Minor
Attachments: dirlisting.patch
attached is a patch that enhances DirListingExportCommand to allow specific node types to be ignored when generating the html directory listing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JCR-165) add ability to ignore specific node types when generating webdav directory listing
Posted by "Brian Moseley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-165?page=comments#action_12320650 ]
Brian Moseley commented on JCR-165:
-----------------------------------
i feel okay about the resource having responsibility for taking whatever actions are necessary to fulfill the request. the major limitation of the existing simple server, imo, is that there is a single resource implementation for collections and non-collections. this is not such a big deal in the simple server itself, but when extending the server to add new resource types (calendar home collection, calendar collection, principal collection) etc, the monolithic resource implementation gets more and more complex.
> add ability to ignore specific node types when generating webdav directory listing
> ----------------------------------------------------------------------------------
>
> Key: JCR-165
> URL: http://issues.apache.org/jira/browse/JCR-165
> Project: Jackrabbit
> Type: Improvement
> Versions: 1.0
> Reporter: Brian Moseley
> Priority: Minor
> Attachments: dirlisting.patch
>
> attached is a patch that enhances DirListingExportCommand to allow specific node types to be ignored when generating the html directory listing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JCR-165) add ability to ignore specific node types when generating webdav directory listing
Posted by "Brian Moseley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-165?page=comments#action_12359715 ]
Brian Moseley commented on JCR-165:
-----------------------------------
yeah i looked further and agree with you, no longer an issue.
> add ability to ignore specific node types when generating webdav directory listing
> ----------------------------------------------------------------------------------
>
> Key: JCR-165
> URL: http://issues.apache.org/jira/browse/JCR-165
> Project: Jackrabbit
> Type: Improvement
> Versions: 1.0
> Reporter: Brian Moseley
> Assignee: angela
> Priority: Minor
> Attachments: dirlisting.patch
>
> attached is a patch that enhances DirListingExportCommand to allow specific node types to be ignored when generating the html directory listing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JCR-165) add ability to ignore specific node types when generating webdav directory listing
Posted by "angela (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-165?page=comments#action_12323216 ]
angela commented on JCR-165:
----------------------------
the initial purpose of the simple stuff was (nomen est omen) to provide a easy webdav view to a jcr repository, that does not need exhaustive explanation (in contrast to the jcr-server...).
that was the reason for having one single simple resource. since the simple stuff grew larger, that might be in fact not be handy anymore. however this should not be a big deal (see jcr-server for a impl with many resource classes).
however, tobi i don't see what you mean. and i'm still not very happy with the command-chaind you introduced.... the old story ;)
> add ability to ignore specific node types when generating webdav directory listing
> ----------------------------------------------------------------------------------
>
> Key: JCR-165
> URL: http://issues.apache.org/jira/browse/JCR-165
> Project: Jackrabbit
> Type: Improvement
> Versions: 1.0
> Reporter: Brian Moseley
> Priority: Minor
> Attachments: dirlisting.patch
>
> attached is a patch that enhances DirListingExportCommand to allow specific node types to be ignored when generating the html directory listing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JCR-165) add ability to ignore specific node types when generating webdav directory listing
Posted by "angela (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-165?page=comments#action_12315834 ]
angela commented on JCR-165:
----------------------------
hi brian
thanks for the patch. i think it would be a useful enhancement to provide means to filter certain items. however, i have the impression that this involves more than just the dirlisting, e.g. the response to a propfind request.
second i think it would be better to filter by the nodetype that defines a given item, rather than filter by the nodetype of a given node.
and last but not least one possibly want to hide items with a given name.
we are currently thinking about such an enhancement as well and will keep you informed.
regards
angela
> add ability to ignore specific node types when generating webdav directory listing
> ----------------------------------------------------------------------------------
>
> Key: JCR-165
> URL: http://issues.apache.org/jira/browse/JCR-165
> Project: Jackrabbit
> Type: Improvement
> Versions: 1.0
> Reporter: Brian Moseley
> Priority: Minor
> Attachments: dirlisting.patch
>
> attached is a patch that enhances DirListingExportCommand to allow specific node types to be ignored when generating the html directory listing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (JCR-165) add ability to ignore specific node types when generating webdav directory listing
Posted by "Brian Moseley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-165?page=all ]
Brian Moseley updated JCR-165:
------------------------------
Attachment: dirlisting.patch
> add ability to ignore specific node types when generating webdav directory listing
> ----------------------------------------------------------------------------------
>
> Key: JCR-165
> URL: http://issues.apache.org/jira/browse/JCR-165
> Project: Jackrabbit
> Type: Improvement
> Versions: 1.0
> Reporter: Brian Moseley
> Priority: Minor
> Attachments: dirlisting.patch
>
> attached is a patch that enhances DirListingExportCommand to allow specific node types to be ignored when generating the html directory listing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (JCR-165) add ability to ignore specific node types when generating webdav directory listing
Posted by "angela (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-165?page=all ]
angela resolved JCR-165:
------------------------
Resolution: Won't Fix
Assign To: angela
is obselete with resolution of JCR-249
> add ability to ignore specific node types when generating webdav directory listing
> ----------------------------------------------------------------------------------
>
> Key: JCR-165
> URL: http://issues.apache.org/jira/browse/JCR-165
> Project: Jackrabbit
> Type: Improvement
> Versions: 1.0
> Reporter: Brian Moseley
> Assignee: angela
> Priority: Minor
> Attachments: dirlisting.patch
>
> attached is a patch that enhances DirListingExportCommand to allow specific node types to be ignored when generating the html directory listing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JCR-165) add ability to ignore specific node types when generating webdav directory listing
Posted by "Brian Moseley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-165?page=comments#action_12318667 ]
Brian Moseley commented on JCR-165:
-----------------------------------
> that's an known issue, as discribed in the summary :)
understood. here's an issue to track it :) and the "forwarding" export command that i described is moving up quickly on my priority list, so i wanted to highlight the issue for you before i'm on the hook to write some code for it :)
> add ability to ignore specific node types when generating webdav directory listing
> ----------------------------------------------------------------------------------
>
> Key: JCR-165
> URL: http://issues.apache.org/jira/browse/JCR-165
> Project: Jackrabbit
> Type: Improvement
> Versions: 1.0
> Reporter: Brian Moseley
> Priority: Minor
> Attachments: dirlisting.patch
>
> attached is a patch that enhances DirListingExportCommand to allow specific node types to be ignored when generating the html directory listing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JCR-165) add ability to ignore specific node types when generating webdav directory listing
Posted by "Brian Moseley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-165?page=comments#action_12323247 ]
Brian Moseley commented on JCR-165:
-----------------------------------
agree. my one comment is that any new mechanism needs to be extensible. my chains might be linear, but they do a lot of stuff that the out-of-the-box chains don't do, with every command :)
> add ability to ignore specific node types when generating webdav directory listing
> ----------------------------------------------------------------------------------
>
> Key: JCR-165
> URL: http://issues.apache.org/jira/browse/JCR-165
> Project: Jackrabbit
> Type: Improvement
> Versions: 1.0
> Reporter: Brian Moseley
> Priority: Minor
> Attachments: dirlisting.patch
>
> attached is a patch that enhances DirListingExportCommand to allow specific node types to be ignored when generating the html directory listing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JCR-165) add ability to ignore specific node types when generating webdav directory listing
Posted by "Tobias Strasser (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-165?page=comments#action_12320294 ]
Tobias Strasser commented on JCR-165:
-------------------------------------
i see your problem. but isn't a GET request on a collection something that does not belong to webdav, and should be rather handled in the servlet, than in the export chain? i think we were wrong, including the DirListingCommand. it's a funny example but does not belong here.
> add ability to ignore specific node types when generating webdav directory listing
> ----------------------------------------------------------------------------------
>
> Key: JCR-165
> URL: http://issues.apache.org/jira/browse/JCR-165
> Project: Jackrabbit
> Type: Improvement
> Versions: 1.0
> Reporter: Brian Moseley
> Priority: Minor
> Attachments: dirlisting.patch
>
> attached is a patch that enhances DirListingExportCommand to allow specific node types to be ignored when generating the html directory listing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JCR-165) add ability to ignore specific node types when generating webdav directory listing
Posted by "Brian Moseley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-165?page=comments#action_12318414 ]
Brian Moseley commented on JCR-165:
-----------------------------------
the new ResourceFilter mechanism for filtering PROPFIND results works great, thanks. however, it's not observed in DirListingExportCommand, because the ExportContext does not give access to the DavResource (and even if it did, the DavResource does not give access to its ResourceFilter).
additionally, i would like to be able to write an export command that 1) retrieves the node representing a collection resource and all of its child nodes; 2) makes the nodes available as attributes of the webdav request; and 3) forwards the request to a JSP or other view handler.
perhaps a more extensive refactoring of the import/export subsystem is in order?
> add ability to ignore specific node types when generating webdav directory listing
> ----------------------------------------------------------------------------------
>
> Key: JCR-165
> URL: http://issues.apache.org/jira/browse/JCR-165
> Project: Jackrabbit
> Type: Improvement
> Versions: 1.0
> Reporter: Brian Moseley
> Priority: Minor
> Attachments: dirlisting.patch
>
> attached is a patch that enhances DirListingExportCommand to allow specific node types to be ignored when generating the html directory listing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JCR-165) add ability to ignore specific node types when generating webdav directory listing
Posted by "Tobias Strasser (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-165?page=comments#action_12323246 ]
Tobias Strasser commented on JCR-165:
-------------------------------------
at least we could get some experience with it and a better understanding for what it can be used, and for what not. i think it's cool for stuff like the benchmarking box, or very simple command processing. as soon as the commands alter the context too much, and if they depend on each other, it gets complicated.
we will think of an easier and tighter way to process resource i/o.
> add ability to ignore specific node types when generating webdav directory listing
> ----------------------------------------------------------------------------------
>
> Key: JCR-165
> URL: http://issues.apache.org/jira/browse/JCR-165
> Project: Jackrabbit
> Type: Improvement
> Versions: 1.0
> Reporter: Brian Moseley
> Priority: Minor
> Attachments: dirlisting.patch
>
> attached is a patch that enhances DirListingExportCommand to allow specific node types to be ignored when generating the html directory listing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JCR-165) add ability to ignore specific node types when generating webdav directory listing
Posted by "angela (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-165?page=comments#action_12318595 ]
angela commented on JCR-165:
----------------------------
> not observed in DirListingExportCommand
that's an known issue, as discribed in the summary :)
> add ability to ignore specific node types when generating webdav directory listing
> ----------------------------------------------------------------------------------
>
> Key: JCR-165
> URL: http://issues.apache.org/jira/browse/JCR-165
> Project: Jackrabbit
> Type: Improvement
> Versions: 1.0
> Reporter: Brian Moseley
> Priority: Minor
> Attachments: dirlisting.patch
>
> attached is a patch that enhances DirListingExportCommand to allow specific node types to be ignored when generating the html directory listing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JCR-165) add ability to ignore specific node types when generating webdav directory listing
Posted by "angela (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-165?page=comments#action_12359712 ]
angela commented on JCR-165:
----------------------------
this is not required any more, because you have access to the DavResource. Therefore the listing is now built from the resource members (which is in case of webdav the proper way to do it, i'd say) and not from any child-nodes present in the repository that may or may not have a webdav representation.
i'd say this is not an issue any more. thoughts?
regards
angela
> add ability to ignore specific node types when generating webdav directory listing
> ----------------------------------------------------------------------------------
>
> Key: JCR-165
> URL: http://issues.apache.org/jira/browse/JCR-165
> Project: Jackrabbit
> Type: Improvement
> Versions: 1.0
> Reporter: Brian Moseley
> Priority: Minor
> Attachments: dirlisting.patch
>
> attached is a patch that enhances DirListingExportCommand to allow specific node types to be ignored when generating the html directory listing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JCR-165) add ability to ignore specific node types when generating webdav directory listing
Posted by "Brian Moseley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-165?page=comments#action_12320453 ]
Brian Moseley commented on JCR-165:
-----------------------------------
section 8.4 of RFC 2518 says:
"The semantics of GET are unchanged when applied to a collection, since GET is defined as, "retrieve whatever information (in the form of an entity) is identified by the Request-URI" [RFC2068]. GET when applied to a collection may return the contents of an "index.html" resource, a human-readable view of the contents of the collection, or something else altogether. Hence it is possible that the result of a GET on a collection will bear no correlation to the membership of the collection."
so it's not that GETing a collection doesn't belong to webdav, but rather that the content of the response is undefined. you have to make *some* kind of response, even if you don't want to send a traditional html directory listing.
however you ultimately choose to handle the issue, though, i don't have any problem handing it at the servlet level rather than in the export chain.
> add ability to ignore specific node types when generating webdav directory listing
> ----------------------------------------------------------------------------------
>
> Key: JCR-165
> URL: http://issues.apache.org/jira/browse/JCR-165
> Project: Jackrabbit
> Type: Improvement
> Versions: 1.0
> Reporter: Brian Moseley
> Priority: Minor
> Attachments: dirlisting.patch
>
> attached is a patch that enhances DirListingExportCommand to allow specific node types to be ignored when generating the html directory listing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JCR-165) add ability to ignore specific node types when generating webdav directory listing
Posted by "Brian Moseley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-165?page=comments#action_12323241 ]
Brian Moseley commented on JCR-165:
-----------------------------------
for what it's worth, i now think the chains are overkill as well. i basically have one linear path of commands for each chain in which each command invariably executes. really doesn't require the chain setup. i sort of wish i hadn't pushed and prodded y'all down this road :/
> add ability to ignore specific node types when generating webdav directory listing
> ----------------------------------------------------------------------------------
>
> Key: JCR-165
> URL: http://issues.apache.org/jira/browse/JCR-165
> Project: Jackrabbit
> Type: Improvement
> Versions: 1.0
> Reporter: Brian Moseley
> Priority: Minor
> Attachments: dirlisting.patch
>
> attached is a patch that enhances DirListingExportCommand to allow specific node types to be ignored when generating the html directory listing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JCR-165) add ability to ignore specific node types when generating webdav directory listing
Posted by "angela (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-165?page=comments#action_12315895 ]
angela commented on JCR-165:
----------------------------
apparent 'second' was no precise enough:
i meant , that you rather want to filter those items, that are defined by a given nodetype and not nodes that are of a given nodetype.
> add ability to ignore specific node types when generating webdav directory listing
> ----------------------------------------------------------------------------------
>
> Key: JCR-165
> URL: http://issues.apache.org/jira/browse/JCR-165
> Project: Jackrabbit
> Type: Improvement
> Versions: 1.0
> Reporter: Brian Moseley
> Priority: Minor
> Attachments: dirlisting.patch
>
> attached is a patch that enhances DirListingExportCommand to allow specific node types to be ignored when generating the html directory listing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JCR-165) add ability to ignore specific node types when generating webdav directory listing
Posted by "Brian Moseley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-165?page=comments#action_12359614 ]
Brian Moseley commented on JCR-165:
-----------------------------------
bringing the discussion back to the original issue: in looking at the new DirListingExportHandler, i don't see any filtering of child nodes. did you punt on that?
> add ability to ignore specific node types when generating webdav directory listing
> ----------------------------------------------------------------------------------
>
> Key: JCR-165
> URL: http://issues.apache.org/jira/browse/JCR-165
> Project: Jackrabbit
> Type: Improvement
> Versions: 1.0
> Reporter: Brian Moseley
> Priority: Minor
> Attachments: dirlisting.patch
>
> attached is a patch that enhances DirListingExportCommand to allow specific node types to be ignored when generating the html directory listing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JCR-165) add ability to ignore specific node types when generating webdav directory listing
Posted by "Tobias Strasser (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-165?page=comments#action_12320533 ]
Tobias Strasser commented on JCR-165:
-------------------------------------
sound arguments :-)
after reviewing the code i came to the same conclusion, that a major restructuration is needed in order to handle the export (import) more sophisticated. on a first thought, the object-oriented way, transfering the responsibility to the resource was obvious. but now i think, this should be handled on a more global level. i think there are several steps involved:
- locating the resource (i.e. url -> path mapping)
- identifying the resource (collection, non-collection)
- finding the respective action-handler (GET, PUT, MKCOL, etc..)
- executing the action
- responding to the client
(did i miss some?)
> add ability to ignore specific node types when generating webdav directory listing
> ----------------------------------------------------------------------------------
>
> Key: JCR-165
> URL: http://issues.apache.org/jira/browse/JCR-165
> Project: Jackrabbit
> Type: Improvement
> Versions: 1.0
> Reporter: Brian Moseley
> Priority: Minor
> Attachments: dirlisting.patch
>
> attached is a patch that enhances DirListingExportCommand to allow specific node types to be ignored when generating the html directory listing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira