You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/03/08 01:07:45 UTC

[GitHub] [incubator-druid] gianm commented on issue #7209: Spell checking tool

gianm commented on issue #7209: Spell checking tool
URL: https://github.com/apache/incubator-druid/issues/7209#issuecomment-470764207
 
 
   I'm not sure if a generic spell check is worth it -- there might be way too many false positives and it would just get annoying -- but something that looks only for _specific_ misspellings may be worth it. (Although, of limited usefulness, since it wouldn't be checking very much.)
   
   I'd suggest doing something that can be applied through Maven (rather than IntelliJ inspections) since it's more accessible. Everyone working on Druid has Maven, not everyone has IntelliJ, and it's a better experience when people can verify their own stuff before submitting it up as a PR. The IntelliJ inspection errors won't be obvious until TC runs, which introduces delay in the PR cycle.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org