[GitHub] [mnemonic] bigdata-memory commented on a change in pull request #119: MNEMONIC-535: Use assert function to handle test results and messages…

[GitBox <gi...@apache.org>]

bigdata-memory commented on a change in pull request #119: MNEMONIC-535: Use assert function to handle test results and messages…
URL: https://github.com/apache/mnemonic/pull/119#discussion_r344476510
 
 

 ##########
 File path: mnemonic-core/src/test/java/org/apache/mnemonic/PMDKVolatileMemAllocatorNGTest.java
 ##########
 @@ -60,7 +60,7 @@ public void testMemChunk() {
     for (int idx = 1; idx <= 5; ++idx) {
       int size = randomGenerator.nextInt(1024 * 1024) + 1024 * 1024;
       mch = act.createChunk(size);
-      System.out.println(String.format("[Seq.%d] addr : %X", idx, size, mch.get()));
+      Assert.assertNotNull(mch, String.format("[Seq.%d] size: %d ", idx, size));
 
 Review comment:
   Please try to add "import org.testng.Assert" in the head of this source file, thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services