You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2022/04/05 18:15:32 UTC

[GitHub] [openwhisk] dylanturn opened a new pull request, #5210: Fix/elastic store update

dylanturn opened a new pull request, #5210:
URL: https://github.com/apache/openwhisk/pull/5210

   <!--- Provide a concise summary of your changes in the Title -->
   
   ## Description
   <!--- Provide a detailed description of your changes. -->
   <!--- Include details of what problem you are solving and how your changes are tested. -->
   Bumped the version of elastic4s to 7.10.3 and updated the various classes that implemented this library so that new versions of Opensearch and Elasticseach can be used as activation stores.
   
   ## Related issue and scope
   <!--- Please include a link to a related issue if there is one. -->
   - [X] I opened an issue to propose and discuss this change (#5209)
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Scheduler
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [X] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
   - [X] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
   
   - [ ] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
   - [X] I reviewed the [style guides](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md#coding-standards) and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] style95 commented on a diff in pull request #5210: Fix/elastic store update

Posted by GitBox <gi...@apache.org>.
style95 commented on code in PR #5210:
URL: https://github.com/apache/openwhisk/pull/5210#discussion_r843659170


##########
common/scala/build.gradle:
##########
@@ -89,8 +89,8 @@ dependencies {
     compile "io.reactivex:rxjava:1.3.8"
     compile "io.reactivex:rxjava-reactive-streams:1.2.1"
     compile "com.microsoft.azure:azure-cosmosdb:2.6.2"
+    compile "com.sksamuel.elastic4s:elastic4s-client-esjava_${gradle.scala.depVersion}:7.10.3"

Review Comment:
   I am concerned about the license.
   I didn't look into it deeply but from a certain version of ES-7.x they would no longer support it with the Apache license.
   Not sure we can upgrade the ES version.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] style95 commented on a diff in pull request #5210: Fix/elastic store update

Posted by GitBox <gi...@apache.org>.
style95 commented on code in PR #5210:
URL: https://github.com/apache/openwhisk/pull/5210#discussion_r847855640


##########
common/scala/build.gradle:
##########
@@ -89,8 +89,8 @@ dependencies {
     compile "io.reactivex:rxjava:1.3.8"
     compile "io.reactivex:rxjava-reactive-streams:1.2.1"
     compile "com.microsoft.azure:azure-cosmosdb:2.6.2"
+    compile "com.sksamuel.elastic4s:elastic4s-client-esjava_${gradle.scala.depVersion}:7.10.3"

Review Comment:
   The new scheduler relies on multiple filtered aliases against one ES index.
   I am unclear ES 7.x support this.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] dylanturn commented on pull request #5210: Fix/elastic store update

Posted by GitBox <gi...@apache.org>.
dylanturn commented on PR #5210:
URL: https://github.com/apache/openwhisk/pull/5210#issuecomment-1098131501

   Looking at the latest Travis CI build results:
   
   **Failed Tests**
   `20219.2 Unit Tests` | `20219.4 Multi-Runtime Tests` | `20219.7 Scheduler Tests`
   I checked every play execution on each test and they all looked like they ran just fine. The error seems happen when trying to upload the results.
   Error Message: _"File upload failed."_
   
   **Errored Tests**
   `20219.3 System Tests`
   All the tests (including `:core:scheduler:processScoverageResources` and `:core:scheduler:scoverageClasses`) seem to run fine up to `:tests:testCoverageLean` which failed with a very long error message. Here is an excerpt:
   ```
   system.basic.WskConductorTests > Whisk conductor actions should invoke a conductor action with a continuation FAILED
   
       org.scalatest.exceptions.TestFailedException: error waiting for activation f4847a3c88384251847a3c8838925132 for 120 seconds: No activation record for'f4847a3c88384251847a3c8838925132'
   ```
   
   It's not immediately obvious why the error was thrown, I'll have to do some more investigation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] jiangpengcheng commented on a diff in pull request #5210: Fix/elastic store update

Posted by GitBox <gi...@apache.org>.
jiangpengcheng commented on code in PR #5210:
URL: https://github.com/apache/openwhisk/pull/5210#discussion_r843628221


##########
common/scala/build.gradle:
##########
@@ -89,8 +89,8 @@ dependencies {
     compile "io.reactivex:rxjava:1.3.8"
     compile "io.reactivex:rxjava-reactive-streams:1.2.1"
     compile "com.microsoft.azure:azure-cosmosdb:2.6.2"
+    compile "com.sksamuel.elastic4s:elastic4s-client-esjava_${gradle.scala.depVersion}:7.10.3"

Review Comment:
   I checked that 6.x is not compatible with this PR because 6.x requires a `type` parameter for `index` and `deleteByQuery` method  while 7.x doesn't want it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] dylanturn commented on a diff in pull request #5210: Fix/elastic store update

Posted by GitBox <gi...@apache.org>.
dylanturn commented on code in PR #5210:
URL: https://github.com/apache/openwhisk/pull/5210#discussion_r843952664


##########
common/scala/build.gradle:
##########
@@ -89,8 +89,8 @@ dependencies {
     compile "io.reactivex:rxjava:1.3.8"
     compile "io.reactivex:rxjava-reactive-streams:1.2.1"
     compile "com.microsoft.azure:azure-cosmosdb:2.6.2"
+    compile "com.sksamuel.elastic4s:elastic4s-client-esjava_${gradle.scala.depVersion}:7.10.3"

Review Comment:
   > I didn't look into it deeply but from a certain version of ES-7.x they would no longer support it with the Apache license.
   What wouldn't they support? Elastic changed the license model sometime after 7.10.x, so this is still entirely covered Apache 2.0.
   
   It's also worth mentioning we don't _have_ to use Elasticsearch. This update makes it possible to use Opensearch, which is covered entirely by Apache 2.0.



##########
common/scala/build.gradle:
##########
@@ -89,8 +89,8 @@ dependencies {
     compile "io.reactivex:rxjava:1.3.8"
     compile "io.reactivex:rxjava-reactive-streams:1.2.1"
     compile "com.microsoft.azure:azure-cosmosdb:2.6.2"
+    compile "com.sksamuel.elastic4s:elastic4s-client-esjava_${gradle.scala.depVersion}:7.10.3"

Review Comment:
   > I didn't look into it deeply but from a certain version of ES-7.x they would no longer support it with the Apache license.
   
   What wouldn't they support? Elastic changed the license model sometime after 7.10.x, so this is still entirely covered Apache 2.0.
   
   It's also worth mentioning we don't _have_ to use Elasticsearch. This update makes it possible to use Opensearch, which is covered entirely by Apache 2.0.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] dylanturn commented on a diff in pull request #5210: Fix/elastic store update

Posted by GitBox <gi...@apache.org>.
dylanturn commented on code in PR #5210:
URL: https://github.com/apache/openwhisk/pull/5210#discussion_r847445069


##########
.github/workflows/gradle-build.yml:
##########
@@ -0,0 +1,36 @@
+# This workflow uses actions that are not certified by GitHub.

Review Comment:
   Just a quick update, I tried to build the project locally again and got the following error:
   ```
   Execution failed for task ':core:scheduler:generateProto'.
   > Could not resolve all files for configuration ':core:scheduler:protobufToolsLocator_protoc'.
      > Could not find protoc-osx-aarch_64.exe (com.google.protobuf:protoc:3.4.0).
        Searched in the following locations:
            https://repo.maven.apache.org/maven2/com/google/protobuf/protoc/3.4.0/protoc-3.4.0-osx-aarch_64.exe
   ```
   
   I must admit, this is my first time with Scala and Gradle, and while I think I might know what happened, I'm still trying to work out how to go about fixing it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] rabbah commented on pull request #5210: Fix/elastic store update

Posted by GitBox <gi...@apache.org>.
rabbah commented on PR #5210:
URL: https://github.com/apache/openwhisk/pull/5210#issuecomment-1089199875

   Thanks @dylanturn for the contribution 🎉 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] dylanturn commented on pull request #5210: Fix/elastic store update

Posted by GitBox <gi...@apache.org>.
dylanturn commented on PR #5210:
URL: https://github.com/apache/openwhisk/pull/5210#issuecomment-1089342148

   > For the record, I'm trying to work out how to sign the CLA.
   
   Quick update. I've submitted a signed CLA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] codecov-commenter commented on pull request #5210: Fix/elastic store update

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #5210:
URL: https://github.com/apache/openwhisk/pull/5210#issuecomment-1097540133

   # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/5210?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#5210](https://codecov.io/gh/apache/openwhisk/pull/5210?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (87b3dbd) into [master](https://codecov.io/gh/apache/openwhisk/commit/829e734c759e8cf188e30c22d7f96f69ebfb1a97?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (829e734) will **decrease** coverage by `39.69%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #5210       +/-   ##
   ==========================================
   - Coverage   44.24%   4.55%   -39.70%     
   ==========================================
     Files         238     238               
     Lines       13957   13956        -1     
     Branches      570     565        -5     
   ==========================================
   - Hits         6175     635     -5540     
   - Misses       7782   13321     +5539     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/5210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/elasticsearch/ElasticSearchActivationStore.scala](https://codecov.io/gh/apache/openwhisk/pull/5210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvZWxhc3RpY3NlYXJjaC9FbGFzdGljU2VhcmNoQWN0aXZhdGlvblN0b3JlLnNjYWxh) | `0.00% <0.00%> (-58.83%)` | :arrow_down: |
   | [...scheduler/queue/ElasticSearchDurationChecker.scala](https://codecov.io/gh/apache/openwhisk/pull/5210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zY2hlZHVsZXIvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9vcGVud2hpc2svY29yZS9zY2hlZHVsZXIvcXVldWUvRWxhc3RpY1NlYXJjaER1cmF0aW9uQ2hlY2tlci5zY2FsYQ==) | `0.00% <0.00%> (-80.77%)` | :arrow_down: |
   | [.../main/scala/org/apache/openwhisk/core/WarmUp.scala](https://codecov.io/gh/apache/openwhisk/pull/5210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvV2FybVVwLnNjYWxh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ain/scala/org/apache/openwhisk/spi/SpiLoader.scala](https://codecov.io/gh/apache/openwhisk/pull/5210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL3NwaS9TcGlMb2FkZXIuc2NhbGE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...scala/org/apache/openwhisk/core/FeatureFlags.scala](https://codecov.io/gh/apache/openwhisk/pull/5210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvRmVhdHVyZUZsYWdzLnNjYWxh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...la/org/apache/openwhisk/http/BasicRasService.scala](https://codecov.io/gh/apache/openwhisk/pull/5210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2h0dHAvQmFzaWNSYXNTZXJ2aWNlLnNjYWxh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...pache/openwhisk/http/LenientSprayJsonSupport.scala](https://codecov.io/gh/apache/openwhisk/pull/5210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2h0dHAvTGVuaWVudFNwcmF5SnNvblN1cHBvcnQuc2NhbGE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ache/openwhisk/core/database/DocumentFactory.scala](https://codecov.io/gh/apache/openwhisk/pull/5210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvRG9jdW1lbnRGYWN0b3J5LnNjYWxh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...che/openwhisk/core/invoker/LogStoreCollector.scala](https://codecov.io/gh/apache/openwhisk/pull/5210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvaW52b2tlci9Mb2dTdG9yZUNvbGxlY3Rvci5zY2FsYQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...he/openwhisk/core/invoker/NamespaceBlacklist.scala](https://codecov.io/gh/apache/openwhisk/pull/5210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvaW52b2tlci9OYW1lc3BhY2VCbGFja2xpc3Quc2NhbGE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [120 more](https://codecov.io/gh/apache/openwhisk/pull/5210/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/5210?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/5210?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [829e734...87b3dbd](https://codecov.io/gh/apache/openwhisk/pull/5210?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] jiangpengcheng commented on a diff in pull request #5210: Fix/elastic store update

Posted by GitBox <gi...@apache.org>.
jiangpengcheng commented on code in PR #5210:
URL: https://github.com/apache/openwhisk/pull/5210#discussion_r843617579


##########
.github/workflows/gradle-build.yml:
##########
@@ -0,0 +1,36 @@
+# This workflow uses actions that are not certified by GitHub.

Review Comment:
   there are some unittests for es in `tests/src/test/scala/org/apache/openwhisk/core/database/elasticsearch/ElasticSearchActivationStoreTests.scala` which is using `testcontainers`, so I think you can use it to run tests on your laptop?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] dylanturn commented on pull request #5210: Fix/elastic store update

Posted by GitBox <gi...@apache.org>.
dylanturn commented on PR #5210:
URL: https://github.com/apache/openwhisk/pull/5210#issuecomment-1089143354

   For the record, I'm trying to work out how to sign the CLA. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] style95 commented on a diff in pull request #5210: Fix/elastic store update

Posted by GitBox <gi...@apache.org>.
style95 commented on code in PR #5210:
URL: https://github.com/apache/openwhisk/pull/5210#discussion_r929532199


##########
common/scala/build.gradle:
##########
@@ -89,8 +89,8 @@ dependencies {
     compile "io.reactivex:rxjava:1.3.8"
     compile "io.reactivex:rxjava-reactive-streams:1.2.1"
     compile "com.microsoft.azure:azure-cosmosdb:2.6.2"
+    compile "com.sksamuel.elastic4s:elastic4s-client-esjava_${gradle.scala.depVersion}:7.10.3"

Review Comment:
   Hm..
   If we don't use `multiple filtered aliases`, it would create a huge number of indices for all namespaces even if they rarely invoke any actions.
   It is necessary to have shared indices for namespaces without less invocation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] style95 commented on a diff in pull request #5210: Fix/elastic store update

Posted by GitBox <gi...@apache.org>.
style95 commented on code in PR #5210:
URL: https://github.com/apache/openwhisk/pull/5210#discussion_r847880602


##########
common/scala/build.gradle:
##########
@@ -89,8 +89,8 @@ dependencies {
     compile "io.reactivex:rxjava:1.3.8"
     compile "io.reactivex:rxjava-reactive-streams:1.2.1"
     compile "com.microsoft.azure:azure-cosmosdb:2.6.2"
+    compile "com.sksamuel.elastic4s:elastic4s-client-esjava_${gradle.scala.depVersion}:7.10.3"

Review Comment:
   Are you using FPCScheduler too?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] dylanturn commented on a diff in pull request #5210: Fix/elastic store update

Posted by GitBox <gi...@apache.org>.
dylanturn commented on code in PR #5210:
URL: https://github.com/apache/openwhisk/pull/5210#discussion_r849575708


##########
common/scala/build.gradle:
##########
@@ -89,8 +89,8 @@ dependencies {
     compile "io.reactivex:rxjava:1.3.8"
     compile "io.reactivex:rxjava-reactive-streams:1.2.1"
     compile "com.microsoft.azure:azure-cosmosdb:2.6.2"
+    compile "com.sksamuel.elastic4s:elastic4s-client-esjava_${gradle.scala.depVersion}:7.10.3"

Review Comment:
   Good point, I don't think I am.
   
   That said, I can't find anything in the Elasticsearch documentation or release notes that suggests "_multiple filtered aliases against one ES index_" would have been removed.
   
   Was it something you read that gave you cause for concern?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] jiangpengcheng commented on a diff in pull request #5210: Fix/elastic store update

Posted by GitBox <gi...@apache.org>.
jiangpengcheng commented on code in PR #5210:
URL: https://github.com/apache/openwhisk/pull/5210#discussion_r853646455


##########
common/scala/build.gradle:
##########
@@ -89,8 +89,8 @@ dependencies {
     compile "io.reactivex:rxjava:1.3.8"
     compile "io.reactivex:rxjava-reactive-streams:1.2.1"
     compile "com.microsoft.azure:azure-cosmosdb:2.6.2"
+    compile "com.sksamuel.elastic4s:elastic4s-client-esjava_${gradle.scala.depVersion}:7.10.3"

Review Comment:
   @style95 I think new scheduler doen't rely on `multiple filtered aliase`, and even not on elasticsearch
   
   we are using `multiple filtered aliase` to organize activations by namespaces in our downstream, we may need to consider changing that



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] dylanturn commented on a diff in pull request #5210: Fix/elastic store update

Posted by GitBox <gi...@apache.org>.
dylanturn commented on code in PR #5210:
URL: https://github.com/apache/openwhisk/pull/5210#discussion_r843955764


##########
.github/workflows/gradle-build.yml:
##########
@@ -0,0 +1,36 @@
+# This workflow uses actions that are not certified by GitHub.

Review Comment:
   It failed when trying to download one of the dependencies. I'll try again so I can get the dependency name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] dylanturn commented on a diff in pull request #5210: Fix/elastic store update

Posted by GitBox <gi...@apache.org>.
dylanturn commented on code in PR #5210:
URL: https://github.com/apache/openwhisk/pull/5210#discussion_r847880046


##########
common/scala/build.gradle:
##########
@@ -89,8 +89,8 @@ dependencies {
     compile "io.reactivex:rxjava:1.3.8"
     compile "io.reactivex:rxjava-reactive-streams:1.2.1"
     compile "com.microsoft.azure:azure-cosmosdb:2.6.2"
+    compile "com.sksamuel.elastic4s:elastic4s-client-esjava_${gradle.scala.depVersion}:7.10.3"

Review Comment:
   > The new scheduler relies on multiple filtered aliases against one ES index. I am unclear ES 7.x support this.
   
   I'm not sure what to tell you, I've been using OpenWhisk with my ES 7.10 (Opensearch) cluster for the last week without any issues...
   
   For what it's worth I'm working on updating the tests so they work correctly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] rabbah commented on a diff in pull request #5210: Fix/elastic store update

Posted by GitBox <gi...@apache.org>.
rabbah commented on code in PR #5210:
URL: https://github.com/apache/openwhisk/pull/5210#discussion_r843168017


##########
.github/workflows/gradle-build.yml:
##########
@@ -0,0 +1,36 @@
+# This workflow uses actions that are not certified by GitHub.

Review Comment:
   Is the goal here to run GHA instead of using Travis?
   In any case this change seems orthogonal to the rest of the PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] style95 commented on a diff in pull request #5210: Fix/elastic store update

Posted by GitBox <gi...@apache.org>.
style95 commented on code in PR #5210:
URL: https://github.com/apache/openwhisk/pull/5210#discussion_r843461487


##########
common/scala/build.gradle:
##########
@@ -89,8 +89,8 @@ dependencies {
     compile "io.reactivex:rxjava:1.3.8"
     compile "io.reactivex:rxjava-reactive-streams:1.2.1"
     compile "com.microsoft.azure:azure-cosmosdb:2.6.2"
+    compile "com.sksamuel.elastic4s:elastic4s-client-esjava_${gradle.scala.depVersion}:7.10.3"

Review Comment:
   Is this compatible with elasticsearch 6.x version?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] dylanturn commented on a diff in pull request #5210: Fix/elastic store update

Posted by GitBox <gi...@apache.org>.
dylanturn commented on code in PR #5210:
URL: https://github.com/apache/openwhisk/pull/5210#discussion_r843178269


##########
.github/workflows/gradle-build.yml:
##########
@@ -0,0 +1,36 @@
+# This workflow uses actions that are not certified by GitHub.

Review Comment:
   I created that because I don't have a Travis or Jenkins environment to build this in and  my personal laptop has an M1 chip in it. Additionally, I wanted to be sure that I had fixed the issue before I submitted the PR but left it in because I felt it could be beneficial to others who might want to build the project but don't have much Jenkins, Travis, or Gradle experience.
   
   The action only runs when triggered manually.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org