You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by se...@apache.org on 2015/07/06 19:46:08 UTC

directory-kerby git commit: Checkstyle: enable MethodName check, add suppression for tests

Repository: directory-kerby
Updated Branches:
  refs/heads/master cc6749095 -> a093e289a


Checkstyle: enable MethodName check, add suppression for tests


Project: http://git-wip-us.apache.org/repos/asf/directory-kerby/repo
Commit: http://git-wip-us.apache.org/repos/asf/directory-kerby/commit/a093e289
Tree: http://git-wip-us.apache.org/repos/asf/directory-kerby/tree/a093e289
Diff: http://git-wip-us.apache.org/repos/asf/directory-kerby/diff/a093e289

Branch: refs/heads/master
Commit: a093e289ad598c44b4d56aa7b46868fe2aa2c62c
Parents: cc67490
Author: Stefan Seelmann <ma...@stefan-seelmann.de>
Authored: Mon Jul 6 19:45:25 2015 +0200
Committer: Stefan Seelmann <ma...@stefan-seelmann.de>
Committed: Mon Jul 6 19:45:25 2015 +0200

----------------------------------------------------------------------
 docs/kerby-checkstyle.xml                       |  2 +-
 .../kerb-crypto/src/checkstyle/suppressions.xml | 30 ++++++++++++++++++++
 pom.xml                                         | 12 ++++++++
 3 files changed, 43 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/a093e289/docs/kerby-checkstyle.xml
----------------------------------------------------------------------
diff --git a/docs/kerby-checkstyle.xml b/docs/kerby-checkstyle.xml
index d326815..239edbd 100644
--- a/docs/kerby-checkstyle.xml
+++ b/docs/kerby-checkstyle.xml
@@ -57,7 +57,7 @@
         <module name="LocalFinalVariableName"/>
         <module name="LocalVariableName"/>
         <module name="MemberName"/>
-        <!-- module name="MethodName"/ -->
+        <module name="MethodName"/>
         <module name="PackageName"/>
         <module name="ParameterName"/>
         <module name="StaticVariableName"/>

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/a093e289/kerby-kerb/kerb-crypto/src/checkstyle/suppressions.xml
----------------------------------------------------------------------
diff --git a/kerby-kerb/kerb-crypto/src/checkstyle/suppressions.xml b/kerby-kerb/kerb-crypto/src/checkstyle/suppressions.xml
new file mode 100644
index 0000000..be86123
--- /dev/null
+++ b/kerby-kerb/kerb-crypto/src/checkstyle/suppressions.xml
@@ -0,0 +1,30 @@
+<?xml version="1.0"?>
+
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+  
+  http://www.apache.org/licenses/LICENSE-2.0
+  
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an
+  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  KIND, either express or implied.  See the License for the
+  specific language governing permissions and limitations
+  under the License.
+-->
+
+<!DOCTYPE suppressions PUBLIC
+    "-//Puppy Crawl//DTD Suppressions 1.1//EN"
+    "http://www.puppycrawl.com/dtds/suppressions_1_1.dtd">
+
+<suppressions>
+    <!-- Allow method names with underscore -->
+    <suppress files=".*Test" checks="MethodName" />
+
+</suppressions>

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/a093e289/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 19b939c..fa74130 100644
--- a/pom.xml
+++ b/pom.xml
@@ -298,6 +298,18 @@
         <checkstyle.dir>${basedir}/../../docs</checkstyle.dir>
       </properties>
     </profile>
+
+    <profile>
+      <id>activate-checkstyle-supression</id>
+      <activation>
+        <file>
+          <exists>${basedir}/src/checkstyle/suppressions.xml</exists>
+        </file>
+      </activation>
+      <properties>
+        <checkstyle.suppressions.location>${basedir}/src/checkstyle/suppressions.xml</checkstyle.suppressions.location>
+      </properties>
+    </profile>
   </profiles>
 
   <repositories>