You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Andrew Wang (JIRA)" <ji...@apache.org> on 2014/10/06 22:20:34 UTC
[jira] [Commented] (HADOOP-10404) Some accesses to
DomainSocketWatcher#closed are not protected by lock
[ https://issues.apache.org/jira/browse/HADOOP-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14160867#comment-14160867 ]
Andrew Wang commented on HADOOP-10404:
--------------------------------------
LGTM +1
> Some accesses to DomainSocketWatcher#closed are not protected by lock
> ---------------------------------------------------------------------
>
> Key: HADOOP-10404
> URL: https://issues.apache.org/jira/browse/HADOOP-10404
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-10404.003.patch, HADOOP-10404.1.patch, HADOOP-10404.2.patch
>
>
> {code}
> * Lock which protects toAdd, toRemove, and closed.
> */
> private final ReentrantLock lock = new ReentrantLock();
> {code}
> There're two places, NotificationHandler.handle() and kick(), where access to closed is without holding lock.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)