You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/12/22 12:36:46 UTC

[GitHub] [solr] janhoy commented on pull request #468: ensures that test code does not depend on log level

janhoy commented on pull request #468:
URL: https://github.com/apache/solr/pull/468#issuecomment-999545613


   Probably no need for a JIRA. And executing logic inside a logger.info() call sounds like a bug, since if you run tests on WARN level it will be have differently. Wrapping logging in isXxxEnabled() is normally done for TRACE and DEBUG for performance reasons, so not using it for INFO is ok.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org