You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/07/04 09:10:16 UTC
[GitHub] [incubator-uniffle] pan3793 opened a new pull request, #13: Upgrade gRPC to support Apple Silicon
pan3793 opened a new pull request, #13:
URL: https://github.com/apache/incubator-uniffle/pull/13
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://github.com/Tencent/Firestorm/blob/master/CONTRIBUTING.md
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Upgrade gRPC to support Apple Silicon.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To support build on Apple M1 chips.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, gRPC, protobuf related dependencies are updated, and developers who use Apple M1 chips can build now.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
```
➜ apache-uniffle git:(proto) java -version
openjdk version "1.8.0_332"
OpenJDK Runtime Environment (Zulu 8.62.0.19-CA-macos-aarch64) (build 1.8.0_332-b09)
OpenJDK 64-Bit Server VM (Zulu 8.62.0.19-CA-macos-aarch64) (build 25.332-b09, mixed mode)
```
```
mvn clean install -DskipTests
```
```
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Remote Shuffle Service Project Parent POM 0.6.0-snapshot:
[INFO]
[INFO] Remote Shuffle Service Project Parent POM .......... SUCCESS [ 1.476 s]
[INFO] Remote Shuffle Service Protocols ................... SUCCESS [ 3.966 s]
[INFO] Remote Shuffle Service Common ...................... SUCCESS [ 0.451 s]
[INFO] Coordinator ........................................ SUCCESS [ 3.589 s]
[INFO] rss-internal-client ................................ SUCCESS [ 0.718 s]
[INFO] Shuffle Storage .................................... SUCCESS [ 2.137 s]
[INFO] Shuffle Server ..................................... SUCCESS [ 7.720 s]
[INFO] rss-client ......................................... SUCCESS [ 2.015 s]
[INFO] rss-integration-common-test ........................ SUCCESS [ 2.582 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 24.889 s
[INFO] Finished at: 2022-07-04T17:05:26+08:00
[INFO] ------------------------------------------------------------------------
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1173742886
`mvn package -Pspark2` passed
```
[INFO] Reactor Summary for Remote Shuffle Service Project Parent POM 0.6.0-snapshot:
[INFO]
[INFO] Remote Shuffle Service Project Parent POM .......... SUCCESS [ 1.104 s]
[INFO] Remote Shuffle Service Protocols ................... SUCCESS [ 3.248 s]
[INFO] Remote Shuffle Service Common ...................... SUCCESS [ 2.861 s]
[INFO] Coordinator ........................................ SUCCESS [01:06 min]
[INFO] rss-internal-client ................................ SUCCESS [ 0.190 s]
[INFO] Shuffle Storage .................................... SUCCESS [ 20.286 s]
[INFO] Shuffle Server ..................................... SUCCESS [01:30 min]
[INFO] rss-client ......................................... SUCCESS [ 20.063 s]
[INFO] rss-integration-common-test ........................ SUCCESS [06:42 min]
[INFO] rss-client-spark-common ............................ SUCCESS [ 39.579 s]
[INFO] rss-client-spark2 .................................. SUCCESS [ 28.866 s]
[INFO] rss-integration-spark-common-test .................. SUCCESS [06:02 min]
[INFO] rss-integration-spark2-test ........................ SUCCESS [ 9.976 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:29 min
[INFO] Finished at: 2022-07-04T20:06:32+08:00
[INFO] ------------------------------------------------------------------------
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] jerryshao commented on a diff in pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
jerryshao commented on code in PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#discussion_r912994965
##########
pom.xml:
##########
@@ -36,11 +36,12 @@
<properties>
<checkstyle.version>9.3</checkstyle.version>
- <error_prone_annotations.version>2.3.4</error_prone_annotations.version>
+ <error_prone_annotations.version>2.10.0</error_prone_annotations.version>
<execution.root>${user.dir}</execution.root>
<fasterxml.jackson.version>2.10.0</fasterxml.jackson.version>
- <grpc.version>1.33.0</grpc.version>
- <guava.version>30.0-jre</guava.version>
+ <grpc.version>1.47.0</grpc.version>
+ <gson.version>2.9.0</gson.version>
+ <guava.version>31.0.1-jre</guava.version>
Review Comment:
Why should we also bump guava and gson version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] jerryshao commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
jerryshao commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1176029041
> I have tested the compatibility of gRPC client/server.
>
> 1. Higher server with low client is ok.
> 2. Low server with higher client is not ok.
>
> @pan3793
I think we should document this to avoid unexpected issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] LuciferYang commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1176107819
This pr is fine to me and agree with @jerryshao if there is really a compatibility issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] frankliee commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
frankliee commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1173701874
And can you run `mvn package -Pspark2` and `mvn package -Pmr`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on a diff in pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#discussion_r913394164
##########
pom.xml:
##########
@@ -60,8 +61,7 @@
<picocli.version>4.5.2</picocli.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<prometheus.simpleclient.version>0.9.0</prometheus.simpleclient.version>
- <protobuf.version>3.12.0</protobuf.version>
- <protoc.version>3.12.0</protoc.version>
+ <protobuf.version>3.19.2</protobuf.version>
Review Comment:
You should check the [maven repo](https://repo1.maven.org/maven2/com/google/protobuf/protoc/3.17.3/) instead of GitHub release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1176091874
> gRPC
Would you please share your testing code? I test the official hello-world demo, the high version client works well w/ low version server.
Test steps: https://gist.github.com/pan3793/815c20e1fb725c48cfe3838f9651d101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] frankliee commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
frankliee commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1176209447
> @frankliee I reproduce the failure of `MRIntegrationTestBase`, I'm sorry I'm not family w/ MapReduce. I checked the `integration-test/mr/target/surefire-reports/org.apache.uniffle.test.SecondarySortTest-output.txt` and don't find the root cause. Would you please share more about it?
Both MR and Spark leverage a unified gRPC client. You can also manually debug it with by starting a uniffle server (v1.37) with uniffle client(v1.43).
Testing hello world client-server examples cannot cover all APIs used by uniffle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1176221583
Where is the "client jar" configuration in Spark IT like `File file = new File(parentPath, "client-mr/target/shaded");` in MR IT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1178640023
Thanks everyone for reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] colinmjj commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
colinmjj commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1175693633
@pan3793 I think it's ok to upgrade the version of gRPC, and do you have check the shaded configuration for client-mr, client-spark2, client-spark3, is there additional package should be shaded with this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] colinmjj commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
colinmjj commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1178634434
@pan3793 thanks for the contribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1173735546
> but upgrading gRPC is not very good, because client and server in product environment are not easy to be upgraded simultaneously
I don't see a causal relationship between them. If you want a seamless upgrade, you should build a compatibility test to make sure your client and server can work w/ each other in different versions, rather than pin a library version and never do upgrading. Actually, in my experience, the larger the upgrade version span, the greater the risk. The upgrading has a clear request to add native support for Apple Silicon, even w/ no urgent requests, keeping the library update-to-dated is a good practice.
> Uniffle can run on Apple M1 by using x86_64 JVM with Rosetta2
In our testing, building Spark using Rosetta2 costs 2 times time more than native. Native is always the first choice.
> And can you run `mvn package -Pspark2` and `mvn package -Pmr`
Yes, I'm trying. But I think it's not a blocker for mering this one. The CI shows it does not break the current functionalities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on a diff in pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#discussion_r912996812
##########
pom.xml:
##########
@@ -36,11 +36,12 @@
<properties>
<checkstyle.version>9.3</checkstyle.version>
- <error_prone_annotations.version>2.3.4</error_prone_annotations.version>
+ <error_prone_annotations.version>2.10.0</error_prone_annotations.version>
<execution.root>${user.dir}</execution.root>
<fasterxml.jackson.version>2.10.0</fasterxml.jackson.version>
- <grpc.version>1.33.0</grpc.version>
- <guava.version>30.0-jre</guava.version>
+ <grpc.version>1.47.0</grpc.version>
+ <gson.version>2.9.0</gson.version>
+ <guava.version>31.0.1-jre</guava.version>
Review Comment:
w/o upgrading gson and guava, it will violate rules defined by `maven-enforcer-plugin`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] frankliee commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
frankliee commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1176106298
> > I have tested the compatibility of gRPC client/server.
> >
> > 1. Higher server with low client is ok.
> > 2. Low server with higher client is not ok.
> >
> > @pan3793 @colinmjj
>
> Would you please share your testing code? I test the official hello-world demo, the high version client works well w/ low version server. Test steps: https://gist.github.com/pan3793/815c20e1fb725c48cfe3838f9651d101
I directly test uniffle client with uniffle server.
To reproduce it, you could just replace rss-client jar (see MRIntegrationTestBase).
`File file = new File(parentPath, "client-mr/target/shaded"); `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1173604167
Hi @pan3793, thanks for the patch.
According to our experience, some tests will fail on Apple Silicon AArch64 JDK.
Please run `maven clean package` without `-DskipTests` to check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on a diff in pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#discussion_r913064469
##########
pom.xml:
##########
@@ -36,11 +36,12 @@
<properties>
<checkstyle.version>9.3</checkstyle.version>
- <error_prone_annotations.version>2.3.4</error_prone_annotations.version>
+ <error_prone_annotations.version>2.10.0</error_prone_annotations.version>
<execution.root>${user.dir}</execution.root>
<fasterxml.jackson.version>2.10.0</fasterxml.jackson.version>
- <grpc.version>1.33.0</grpc.version>
- <guava.version>30.0-jre</guava.version>
+ <grpc.version>1.47.0</grpc.version>
+ <gson.version>2.9.0</gson.version>
+ <guava.version>31.0.1-jre</guava.version>
Review Comment:
Found and fixed some issues in Spark3 IT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1173760211
`mvn package -Pmr` passed
```
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Remote Shuffle Service Project Parent POM 0.6.0-snapshot:
[INFO]
[INFO] Remote Shuffle Service Project Parent POM .......... SUCCESS [ 1.029 s]
[INFO] Remote Shuffle Service Protocols ................... SUCCESS [ 3.097 s]
[INFO] Remote Shuffle Service Common ...................... SUCCESS [ 2.993 s]
[INFO] Coordinator ........................................ SUCCESS [01:05 min]
[INFO] rss-internal-client ................................ SUCCESS [ 0.144 s]
[INFO] Shuffle Storage .................................... SUCCESS [ 22.415 s]
[INFO] Shuffle Server ..................................... SUCCESS [01:29 min]
[INFO] rss-client ......................................... SUCCESS [ 18.890 s]
[INFO] rss-integration-common-test ........................ SUCCESS [06:45 min]
[INFO] rss-client-mr ...................................... SUCCESS [ 16.360 s]
[INFO] rss-integration-mr-test ............................ SUCCESS [03:11 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:36 min
[INFO] Finished at: 2022-07-04T20:24:58+08:00
[INFO] ------------------------------------------------------------------------
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1173934325
# [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/13?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@ec00ad9`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #13 +/- ##
=========================================
Coverage ? 56.23%
Complexity ? 1167
=========================================
Files ? 152
Lines ? 8397
Branches ? 812
=========================================
Hits ? 4722
Misses ? 3410
Partials ? 265
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/13?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/13?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ec00ad9...b76ae89](https://codecov.io/gh/apache/incubator-uniffle/pull/13?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1176491177
> I know this is not easy because getting MR stack is difficult in local.
What I mean is not easy is to build a cross-version **Spark** IT.
> The reproduction is complicated ... 3) switch to the master branch and recompile ...
It's clear to me when you said "See MRIntegrationTestBase `File file = new File(parentPath, "client-mr/target/shaded");`". But for step 3, it's better to switch `ec00ad9`, the commit which I cut the branch out, the master has gone ahead.
> but it is better to notify the client/server should be the same version in the document.
I would prefer to dig out the root cause before documenting the conclusion. My first round of cross-version testing failed but the following rounds were successful. And the first-round failure is because I put the new MR client jar to a temp folder, if there are some temp files deleted by other processes, the test will fail w/
```
java.io.IOException: /home/chengpan/.docker/run/docker-cli-api.sock: No such file or directory
at org.apache.uniffle.test.WordCountTest.wordCountTest(WordCountTest.java:66)
```
And if I put the client-mr jar build w/ new gRPC version to an immutable folder, then IT passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
kaijchen commented on code in PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#discussion_r913078372
##########
pom.xml:
##########
@@ -36,11 +36,12 @@
<properties>
<checkstyle.version>9.3</checkstyle.version>
- <error_prone_annotations.version>2.3.4</error_prone_annotations.version>
+ <error_prone_annotations.version>2.10.0</error_prone_annotations.version>
<execution.root>${user.dir}</execution.root>
<fasterxml.jackson.version>2.10.0</fasterxml.jackson.version>
- <grpc.version>1.33.0</grpc.version>
- <guava.version>30.0-jre</guava.version>
+ <grpc.version>1.47.0</grpc.version>
+ <gson.version>2.9.0</gson.version>
+ <guava.version>31.0.1-jre</guava.version>
Review Comment:
> Found and fixed some issues in Spark3 IT
Thanks for digging out this issue, I remember the same issue was encountered during previous attempts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1174530848
> @pan3793 Could you show the difference between and after this pr in description?
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1176190867
@frankliee I reproduce the failure of `MRIntegrationTestBase`, I'm sorry I'm not family w/ MapReduce. I checked the `integration-test/mr/target/surefire-reports/org.apache.uniffle.test.SecondarySortTest-output.txt` and don't find the root cause. Would you please share more about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1176292080
> > > I have tested the compatibility of gRPC client/server.
> > >
> > > 1. Higher server with low client is ok.
> > > 2. Low server with higher client is not ok.
> > >
> > > @pan3793 @colinmjj
> >
> >
> > Would you please share your testing code? I test the official hello-world demo, the high version client works well w/ low version server. Test steps: https://gist.github.com/pan3793/815c20e1fb725c48cfe3838f9651d101
>
> I directly test uniffle client with uniffle server. To reproduce it, you could just replace rss-client jar (v1.33 and v1.47).
>
> See MRIntegrationTestBase `File file = new File(parentPath, "client-mr/target/shaded"); `
I try this way again, and the test passed. Please attach your failure stack traces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1176512270
> and do you have check the shaded configuration for client-mr, client-spark2, client-spark3, is there additional package should be shaded with this PR?
@colinmjj I check the `client-mr`, I don't think the upgrading introduces any additional package that should be shaded. But I think we have issues with the master branch. e.g. netty and lz4 have native libraries in the jar, the relocation does not consider the native libraries at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] colinmjj commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
colinmjj commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1178633696
What changes were proposed in this pull request?
Upgrade gRPC to support Apple Silicon.
Why are the changes needed?
To support build on Apple M1 chips.
Does this PR introduce any user-facing change?
Yes, gRPC, protobuf related dependencies are updated, and developers who use Apple M1 chips can build now.
How was this patch tested?
local test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1176101850
According to [gRPC Versioning Guide](https://github.com/grpc/grpc/blob/master/doc/versioning.md), there is only backward compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on a diff in pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#discussion_r913397272
##########
pom.xml:
##########
@@ -60,8 +61,7 @@
<picocli.version>4.5.2</picocli.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<prometheus.simpleclient.version>0.9.0</prometheus.simpleclient.version>
- <protobuf.version>3.12.0</protobuf.version>
- <protoc.version>3.12.0</protoc.version>
+ <protobuf.version>3.19.2</protobuf.version>
Review Comment:
it's a funny thing, they just copy and rename the file... both file has the same md5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] LuciferYang commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1174545903
@pan3793
Hm... without this pr, I test the following commands in my Apple Silicon, all commands seem to have succeeded
```
mvn clean install -Dos.detected.classifier=osx-x86_64
mvn package -Pspark2 -Dos.detected.classifier=osx-x86_64
mvn package -Pmr -Dos.detected.classifier=osx-x86_64
```
I use native jdk. Will this way be slower than current pr? Is this acceptable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] colinmjj commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
colinmjj commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1176026164
> 2\. w server with higher client is not o
@frankliee I think it can be documented and suggest user to have the same version of client/server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
kaijchen commented on code in PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#discussion_r913368864
##########
pom.xml:
##########
@@ -60,8 +61,7 @@
<picocli.version>4.5.2</picocli.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<prometheus.simpleclient.version>0.9.0</prometheus.simpleclient.version>
- <protobuf.version>3.12.0</protobuf.version>
- <protoc.version>3.12.0</protoc.version>
+ <protobuf.version>3.19.2</protobuf.version>
Review Comment:
Seems native M1 support was introduced in [v3.20.1](https://github.com/protocolbuffers/protobuf/releases/tag/v3.20.1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on a diff in pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#discussion_r913369870
##########
pom.xml:
##########
@@ -60,8 +61,7 @@
<picocli.version>4.5.2</picocli.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<prometheus.simpleclient.version>0.9.0</prometheus.simpleclient.version>
- <protobuf.version>3.12.0</protobuf.version>
- <protoc.version>3.12.0</protoc.version>
+ <protobuf.version>3.19.2</protobuf.version>
Review Comment:
Not exactly, it is from [v3.17.3](https://github.com/protocolbuffers/protobuf/releases/tag/v3.17.3)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] frankliee commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
frankliee commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1176962586
> > I know this is not easy because getting MR stack is difficult in local.
>
> What I mean "not easy“ is to build a cross-version **Spark IT** that covers all gRPC APIs used by RSS.
>
> > The reproduction is complicated ... 3) switch to the master branch and recompile ...
>
> It's clear to me when you said "See MRIntegrationTestBase `File file = new File(parentPath, "client-mr/target/shaded");`". But for step 3, it's better to switch back to `ec00ad9`, which is the commit I cut the branch out, the master has gone ahead.
>
> > but it is better to notify the client/server should be the same version in the document.
>
> I would prefer to dig out the root cause before documenting the conclusion. My first round of cross-version testing failed but the following rounds were successful. And the first-round failure is because I put the new MR client jar to a temp folder, if there are some temp files deleted by other processes during testing, the test will fail w/
>
> ```
> java.io.IOException: /home/chengpan/.docker/run/docker-cli-api.sock: No such file or directory
> at org.apache.uniffle.test.WordCountTest.wordCountTest(WordCountTest.java:66)
> ```
>
> And if I put the client-mr jar build w/ new gRPC version to an immutable folder, then IT passed.
>
> I finally found and checked the MR tasks log, and do not see any related stacks.
The compatibility is ok. I am sorry, and I found the wrong jar is copied...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1176967350
@frankliee thanks for the confirmation. The latest thing is should we wait for gRPC 1.48 which bundles protoc 3.21.1, or get this in first? Because @kaijchen points that protoc-3.17.3 still requires Rosetta 2 (but does not bother developers).
I would prefer to get in this one first to unblock developers who using M1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1176242135
> Spark IT does not have this.
> Both MR and Spark leverage a unified gRPC client. You can also manually debug it with by starting a uniffle server (v1.37) with uniffle client(v1.43).
> Testing hello world client-server examples cannot cover all APIs used by uniffle.
Then it's not easy for me, a newbie to the project, to build ITs that cover all gRPC APIs used by uniffle to verify the cross-version client/server compatibility and find the broken root cause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
kaijchen commented on code in PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#discussion_r912998766
##########
pom.xml:
##########
@@ -36,11 +36,12 @@
<properties>
<checkstyle.version>9.3</checkstyle.version>
- <error_prone_annotations.version>2.3.4</error_prone_annotations.version>
+ <error_prone_annotations.version>2.10.0</error_prone_annotations.version>
<execution.root>${user.dir}</execution.root>
<fasterxml.jackson.version>2.10.0</fasterxml.jackson.version>
- <grpc.version>1.33.0</grpc.version>
- <guava.version>30.0-jre</guava.version>
+ <grpc.version>1.47.0</grpc.version>
+ <gson.version>2.9.0</gson.version>
+ <guava.version>31.0.1-jre</guava.version>
Review Comment:
They are required by newer version grpc / protobuf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on a diff in pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#discussion_r913010600
##########
pom.xml:
##########
@@ -36,11 +36,12 @@
<properties>
<checkstyle.version>9.3</checkstyle.version>
- <error_prone_annotations.version>2.3.4</error_prone_annotations.version>
+ <error_prone_annotations.version>2.10.0</error_prone_annotations.version>
<execution.root>${user.dir}</execution.root>
<fasterxml.jackson.version>2.10.0</fasterxml.jackson.version>
- <grpc.version>1.33.0</grpc.version>
- <guava.version>30.0-jre</guava.version>
+ <grpc.version>1.47.0</grpc.version>
+ <gson.version>2.9.0</gson.version>
+ <guava.version>31.0.1-jre</guava.version>
Review Comment:
Then we should remove `requireUpperBoundDeps` rule of `maven-enforcer-plugin`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
kaijchen commented on code in PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#discussion_r913012146
##########
pom.xml:
##########
@@ -36,11 +36,12 @@
<properties>
<checkstyle.version>9.3</checkstyle.version>
- <error_prone_annotations.version>2.3.4</error_prone_annotations.version>
+ <error_prone_annotations.version>2.10.0</error_prone_annotations.version>
<execution.root>${user.dir}</execution.root>
<fasterxml.jackson.version>2.10.0</fasterxml.jackson.version>
- <grpc.version>1.33.0</grpc.version>
- <guava.version>30.0-jre</guava.version>
+ <grpc.version>1.47.0</grpc.version>
+ <gson.version>2.9.0</gson.version>
+ <guava.version>31.0.1-jre</guava.version>
Review Comment:
Minimal change was tried in https://github.com/Tencent/Firestorm/pull/185, but there were some issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on a diff in pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#discussion_r913010600
##########
pom.xml:
##########
@@ -36,11 +36,12 @@
<properties>
<checkstyle.version>9.3</checkstyle.version>
- <error_prone_annotations.version>2.3.4</error_prone_annotations.version>
+ <error_prone_annotations.version>2.10.0</error_prone_annotations.version>
<execution.root>${user.dir}</execution.root>
<fasterxml.jackson.version>2.10.0</fasterxml.jackson.version>
- <grpc.version>1.33.0</grpc.version>
- <guava.version>30.0-jre</guava.version>
+ <grpc.version>1.47.0</grpc.version>
+ <gson.version>2.9.0</gson.version>
+ <guava.version>31.0.1-jre</guava.version>
Review Comment:
Then we should remove `maven-enforcer-plugin`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on a diff in pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#discussion_r913066014
##########
pom.xml:
##########
@@ -36,11 +36,12 @@
<properties>
<checkstyle.version>9.3</checkstyle.version>
- <error_prone_annotations.version>2.3.4</error_prone_annotations.version>
+ <error_prone_annotations.version>2.10.0</error_prone_annotations.version>
<execution.root>${user.dir}</execution.root>
<fasterxml.jackson.version>2.10.0</fasterxml.jackson.version>
- <grpc.version>1.33.0</grpc.version>
- <guava.version>30.0-jre</guava.version>
+ <grpc.version>1.47.0</grpc.version>
+ <gson.version>2.9.0</gson.version>
+ <guava.version>31.0.1-jre</guava.version>
Review Comment:
> I would suggest to make the changes minimal to avoid unexpected issues.
I think it's actually the minimal change to meet `requireUpperBoundDeps` requirements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1174550065
> I think it's a workaround, you are using Rosetta2-based `protoc` to generate gRPC & protobuf source codes, but use native javac to compile
You are still using Rosetta2-based `protoc` even with this patch. See https://github.com/protocolbuffers/protobuf/pull/8557.
However, it's easier for new contributors to build this project without extra maven property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] LuciferYang commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1174529545
@pan3793 Could you show the difference between and after this pr in description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] colinmjj merged pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
colinmjj merged PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] frankliee closed pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
frankliee closed pull request #13: Upgrade gRPC to support Apple Silicon
URL: https://github.com/apache/incubator-uniffle/pull/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] frankliee commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
frankliee commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1173753608
> `mvn package -Pspark2` passed
>
> ```
> [INFO] Reactor Summary for Remote Shuffle Service Project Parent POM 0.6.0-snapshot:
> [INFO]
> [INFO] Remote Shuffle Service Project Parent POM .......... SUCCESS [ 1.104 s]
> [INFO] Remote Shuffle Service Protocols ................... SUCCESS [ 3.248 s]
> [INFO] Remote Shuffle Service Common ...................... SUCCESS [ 2.861 s]
> [INFO] Coordinator ........................................ SUCCESS [01:06 min]
> [INFO] rss-internal-client ................................ SUCCESS [ 0.190 s]
> [INFO] Shuffle Storage .................................... SUCCESS [ 20.286 s]
> [INFO] Shuffle Server ..................................... SUCCESS [01:30 min]
> [INFO] rss-client ......................................... SUCCESS [ 20.063 s]
> [INFO] rss-integration-common-test ........................ SUCCESS [06:42 min]
> [INFO] rss-client-spark-common ............................ SUCCESS [ 39.579 s]
> [INFO] rss-client-spark2 .................................. SUCCESS [ 28.866 s]
> [INFO] rss-integration-spark-common-test .................. SUCCESS [06:02 min]
> [INFO] rss-integration-spark2-test ........................ SUCCESS [ 9.976 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17:29 min
> [INFO] Finished at: 2022-07-04T20:06:32+08:00
> [INFO] ------------------------------------------------------------------------
> ```
What about `mvn package -Pspark3`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1176968615
> I would prefer to get in this one first to unblock developers who using M1.
+1, thanks for the investigation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] frankliee commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
frankliee commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1173696453
Thank for you contribution, but upgrading gRPC is not very good, because client and server in product environment are not easy to be upgraded simultaneously.
In fact, Uniffle can run on Apple M1 by using x86_64 JVM with Rosetta2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on a diff in pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#discussion_r913005560
##########
pom.xml:
##########
@@ -36,11 +36,12 @@
<properties>
<checkstyle.version>9.3</checkstyle.version>
- <error_prone_annotations.version>2.3.4</error_prone_annotations.version>
+ <error_prone_annotations.version>2.10.0</error_prone_annotations.version>
<execution.root>${user.dir}</execution.root>
<fasterxml.jackson.version>2.10.0</fasterxml.jackson.version>
- <grpc.version>1.33.0</grpc.version>
- <guava.version>30.0-jre</guava.version>
+ <grpc.version>1.47.0</grpc.version>
+ <gson.version>2.9.0</gson.version>
+ <guava.version>31.0.1-jre</guava.version>
Review Comment:
grpc and protobuf should work well w/ the previous version, the dependency upgrading is trivial
- https://github.com/grpc/grpc-java/pull/9215
- https://github.com/grpc/grpc-java/commit/a8a81e709d8d6c6a05d87932a13117c301dce3ab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] jerryshao commented on a diff in pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
jerryshao commented on code in PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#discussion_r913009514
##########
pom.xml:
##########
@@ -36,11 +36,12 @@
<properties>
<checkstyle.version>9.3</checkstyle.version>
- <error_prone_annotations.version>2.3.4</error_prone_annotations.version>
+ <error_prone_annotations.version>2.10.0</error_prone_annotations.version>
<execution.root>${user.dir}</execution.root>
<fasterxml.jackson.version>2.10.0</fasterxml.jackson.version>
- <grpc.version>1.33.0</grpc.version>
- <guava.version>30.0-jre</guava.version>
+ <grpc.version>1.47.0</grpc.version>
+ <gson.version>2.9.0</gson.version>
+ <guava.version>31.0.1-jre</guava.version>
Review Comment:
I would suggest to make the changes minimal to avoid unexpected issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on a diff in pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#discussion_r913397272
##########
pom.xml:
##########
@@ -60,8 +61,7 @@
<picocli.version>4.5.2</picocli.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<prometheus.simpleclient.version>0.9.0</prometheus.simpleclient.version>
- <protobuf.version>3.12.0</protobuf.version>
- <protoc.version>3.12.0</protoc.version>
+ <protobuf.version>3.19.2</protobuf.version>
Review Comment:
it's a funny thing, they just copy and rename the file... both file has seem md5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] frankliee commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
frankliee commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1176308471
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] frankliee commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
frankliee commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1176016372
I have tested the compatibility of gRPC client/server.
1. Higher server with low client is ok.
2. Low server with higher client is not ok.
@pan3793
@colinmjj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1176495767
> According to [gRPC Versioning Guide](https://github.com/grpc/grpc/blob/master/doc/versioning.md), there is only backward compatibility.
The document says:
> Most importantly, a major version increase must not break wire compatibility with other gRPC implementations so that existing gRPC libraries remain fully interoperable.
> Backward compatibility can be broken by a minor release if the API affected by the change was marked as EXPERIMENTAL upon its introduction.
> That means that no backward incompatible protocol changes are allowed: old clients must continue interoperating correctly with new servers and new servers with old clients.
Then I think there is no compatibility issue that will be introduced by upgrading gRPC deps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1173621392
Run `mvn clean install`, and everything looks OK. But I don't test compute engine related modules.
Spark claims to support Apple Silicon since 3.3.0. Hadoop does not support yet.
```
[INFO] Reactor Summary for Remote Shuffle Service Project Parent POM 0.6.0-snapshot:
[INFO]
[INFO] Remote Shuffle Service Project Parent POM .......... SUCCESS [ 1.204 s]
[INFO] Remote Shuffle Service Protocols ................... SUCCESS [ 5.140 s]
[INFO] Remote Shuffle Service Common ...................... SUCCESS [ 7.320 s]
[INFO] Coordinator ........................................ SUCCESS [01:06 min]
[INFO] rss-internal-client ................................ SUCCESS [ 0.728 s]
[INFO] Shuffle Storage .................................... SUCCESS [ 22.125 s]
[INFO] Shuffle Server ..................................... SUCCESS [01:35 min]
[INFO] rss-client ......................................... SUCCESS [ 21.195 s]
[INFO] rss-integration-common-test ........................ SUCCESS [06:49 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 10:29 min
[INFO] Finished at: 2022-07-04T18:01:11+08:00
[INFO] ------------------------------------------------------------------------
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1173745458
> Constants.SHUFFLE_SERVER_VERSION should be updated to avoid version mismatch
The gRPC library upgrading should not break the protocol, and checked https://github.com/grpc/grpc-java/releases, I don't see any breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] colinmjj commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
colinmjj commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1173741974
Constants.SHUFFLE_SERVER_VERSION should be updated to avoid version mismatch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
kaijchen commented on code in PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#discussion_r913395286
##########
pom.xml:
##########
@@ -60,8 +61,7 @@
<picocli.version>4.5.2</picocli.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<prometheus.simpleclient.version>0.9.0</prometheus.simpleclient.version>
- <protobuf.version>3.12.0</protobuf.version>
- <protoc.version>3.12.0</protoc.version>
+ <protobuf.version>3.19.2</protobuf.version>
Review Comment:
Thanks for the link, seems they both requires Rosetta 2.
```console
$ file protoc-3.17.3-osx-aarch_64.exe protoc-3.20.1-osx-aarch_64.exe
protoc-3.17.3-osx-aarch_64.exe: Mach-O 64-bit executable x86_64
protoc-3.20.1-osx-aarch_64.exe: Mach-O 64-bit executable x86_64
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on a diff in pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#discussion_r913397909
##########
pom.xml:
##########
@@ -60,8 +61,7 @@
<picocli.version>4.5.2</picocli.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<prometheus.simpleclient.version>0.9.0</prometheus.simpleclient.version>
- <protobuf.version>3.12.0</protobuf.version>
- <protoc.version>3.12.0</protoc.version>
+ <protobuf.version>3.19.2</protobuf.version>
Review Comment:
The latest version is right
```
➜ apache-uniffle git:(master) file ~/Downloads/protoc-3.21.2-osx-aarch_64.exe
/Users/chengpan/Downloads/protoc-3.21.2-osx-aarch_64.exe: Mach-O 64-bit executable arm64
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1173755617
> What about `mvn package -Pmr`
Running, will update once completed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
kaijchen commented on code in PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#discussion_r913393215
##########
pom.xml:
##########
@@ -60,8 +61,7 @@
<picocli.version>4.5.2</picocli.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<prometheus.simpleclient.version>0.9.0</prometheus.simpleclient.version>
- <protobuf.version>3.12.0</protobuf.version>
- <protoc.version>3.12.0</protoc.version>
+ <protobuf.version>3.19.2</protobuf.version>
Review Comment:
3.17.3 is still Rosetta, there is only [protoc-3.17.3-osx-x86_64.zip](https://github.com/protocolbuffers/protobuf/releases/download/v3.17.3/protoc-3.17.3-osx-x86_64.zip).
In 3.20.1, there is [protoc-3.20.1-osx-aarch_64.zip](https://github.com/protocolbuffers/protobuf/releases/download/v3.20.1/protoc-3.20.1-osx-aarch_64.zip).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] pan3793 commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1174547031
I think it's a workaround, you are using Rosetta2-based `protoc` to generate gRPC & protobuf source codes, but use native javac to compile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] frankliee commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
frankliee commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1176230729
> Where is the "client jar" configuration in Spark IT like `File file = new File(parentPath, "client-mr/target/shaded");` in MR IT?
Spark IT does not have this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] colinmjj commented on pull request #13: Upgrade gRPC to support Apple Silicon
Posted by GitBox <gi...@apache.org>.
colinmjj commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1176026770
All checks have passed, I prefer +1 for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org